1343787 - Crash in mozilla::MediaShutdownManager::Register

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P1)

Description

[JW Wang [:jwwang] [:jw_wang]]

This bug was filed from the Socorro interface and is 
report bp-51e020b8-569c-44a4-b41c-a096a2170206.
=============================================================

We failed the assertion at
http://searchfox.org/mozilla-central/rev/31b6089ce26fa76459642765115605d50a6c67b4/dom/media/MediaShutdownManager.cpp#98

Somehow the media element tried to create a decoder after shutdown had begun.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1343787. Part 1 - allow MediaShutdownManager::Register() to fail.

Review commit: https://reviewboard.mozilla.org/r/116940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116940/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1343787. Part 2 - move the Register() calls to Load().

Review commit: https://reviewboard.mozilla.org/r/116942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/116942/

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8843176 [details]
Bug 1343787. Part 2 - move the Register() calls to Load().

https://reviewboard.mozilla.org/r/116942/#review118578

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8843175 [details]
Bug 1343787. Part 1 - allow MediaShutdownManager::Register() to fail.

https://reviewboard.mozilla.org/r/116940/#review118580

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/063290664ef1
Part 1 - allow MediaShutdownManager::Register() to fail. r=gerald
https://hg.mozilla.org/integration/autoland/rev/32f15879f537
Part 2 - move the Register() calls to Load(). r=gerald

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/063290664ef1
https://hg.mozilla.org/mozilla-central/rev/32f15879f537

Comment 8

[Ryan VanderMeulen [:RyanVM]]

If I'm reading crash-stats correctly, this affects 52 and 53 as well. Too late for Fx52 at this point, but please request Aurora and ESR52 approval on this when you get a chance.

Comment 9

[Julian Seward [:jseward]]

Indeedy -- this is ranked #12 in the crashes for Windows Aurora of 20170302004002.

Comment 10

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1343787_aurora_53_fix.patch

Comment 11

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8843801 [details] [diff] [review]
1343787_aurora_53_fix.patch

Approval Request Comment
[Feature/Bug causing the regression]:unknown
[User impact if declined]:crash
[Is this code covered by automated tests?]:yes
[Has the fix been verified in Nightly?]:yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]:1336356 must be uplifted first.
[Is the change risky?]:low risk
[Why is the change risky/not risky?]:The change is simple which add error handling to some functions.
[String changes made/needed]:none

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8843801 [details] [diff] [review]
1343787_aurora_53_fix.patch

Part three of a big media shutdown crash fix, please uplift this after the patches in bug 1336345 and bug 1336356.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/9c697f08d301

Comment 14

[Andrei Vaida [:avaida]]

Setting qe-verify- based on JW Wang's assessment on manual testing needs (see Comment 11) and the fact that this fix has automated coverage.

Comment 15

[JW Wang [:jwwang] [:jw_wang]]

Attachment: 1343787_esr52_fix.patch

Comment 16

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8847918 [details] [diff] [review]
1343787_esr52_fix.patch

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration:
User impact if declined: crash
Fix Landed on Version:54
Risk to taking this patch (and alternatives if risky): The change is simple which add error handling to some functions. This patch has been uplifted to 54 and 53.
String or UUID changes made by this patch: none

Comment 17

[Julien Cristau [:jcristau]]

Comment on attachment 8847918 [details] [diff] [review]
1343787_esr52_fix.patch

crash fix, regression in 52, esr52+

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/28287b7f0938