1343797 - Label runnables in dom/media/TextTrackManager.cpp

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Comment 1

[Benjamin Chen [:bechen]]

Attachment: Bug 1343797 - Label runnables in TextTrackManager.cpp.

Review commit: https://reviewboard.mozilla.org/r/123802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123802/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8851487 [details]
Bug 1343797 - Label runnables in TextTrackManager.cpp.

https://reviewboard.mozilla.org/r/123802/#review126208

::: dom/html/TextTrackManager.cpp:583
(Diff revision 1)
>  TextTrackManager::DispatchUpdateCueDisplay()
>  {
>    if (!mUpdateCueDisplayDispatched && !mShutdown &&
>        (mMediaElement->GetHasUserInteraction() || mMediaElement->IsCurrentlyPlaying())) {
>      WEBVTT_LOG("DispatchUpdateCueDisplay");
> -    NS_DispatchToMainThread(NewRunnableMethod(this, &TextTrackManager::UpdateCueDisplay));
> +    SystemGroup::Dispatch("TextTrackManager::UpdateCueDisplay",

Use nsGlobalWindow::Cast(win)->Dispatch() as you did in TextTrackList.

Comment 3

[Benjamin Chen [:bechen]]

Comment on attachment 8851487 [details]
Bug 1343797 - Label runnables in TextTrackManager.cpp.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123802/diff/1-2/

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8851487 [details]
Bug 1343797 - Label runnables in TextTrackManager.cpp.

https://reviewboard.mozilla.org/r/123802/#review126226

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0867aa253746
Label runnables in TextTrackManager.cpp. r=jwwang

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0867aa253746