Closed
Bug 1343797
Opened 7 years ago
Closed 7 years ago
Label runnables in dom/media/TextTrackManager.cpp
Categories
(Core :: Audio/Video: Playback, defect)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: bechen, Assigned: bechen)
References
Details
(Whiteboard: [QDL][TDC-MVP][MEDIA])
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8851487 [details] Bug 1343797 - Label runnables in TextTrackManager.cpp. https://reviewboard.mozilla.org/r/123802/#review126208 ::: dom/html/TextTrackManager.cpp:583 (Diff revision 1) > TextTrackManager::DispatchUpdateCueDisplay() > { > if (!mUpdateCueDisplayDispatched && !mShutdown && > (mMediaElement->GetHasUserInteraction() || mMediaElement->IsCurrentlyPlaying())) { > WEBVTT_LOG("DispatchUpdateCueDisplay"); > - NS_DispatchToMainThread(NewRunnableMethod(this, &TextTrackManager::UpdateCueDisplay)); > + SystemGroup::Dispatch("TextTrackManager::UpdateCueDisplay", Use nsGlobalWindow::Cast(win)->Dispatch() as you did in TextTrackList.
Attachment #8851487 -
Flags: review?(jwwang) → review-
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8851487 [details] Bug 1343797 - Label runnables in TextTrackManager.cpp. https://reviewboard.mozilla.org/r/123802/#review126226
Attachment #8851487 -
Flags: review?(jwwang) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0867aa253746 Label runnables in TextTrackManager.cpp. r=jwwang
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/0867aa253746
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•7 years ago
|
Whiteboard: [QDL][TDC-MVP][MEDIA]
You need to log in
before you can comment on or make changes to this bug.
Description
•