1344002 - Convert nsDisplayOpacity to WR Display Item

Status: RESOLVED INVALID

(Core :: Graphics: WebRender, enhancement)

Comment 1

[Mason Chang [Inactive] [:mchang]]

After looking through the code in nsDisplayList.cpp [1], I'm not sure we need a WR display layer / conversion. nsDisplayOpacity builds a container layer and sets the opacity there, then depends on the children to render themselves. WR already supports a container layer.. which I think means we probably want to keep the same logic for this display item. Does this sound about right to you?

[1] http://searchfox.org/mozilla-central/source/layout/painting/nsDisplayList.cpp#5277

Comment 2

[Markus Stange [:mstange]]

Yes, there is nothing to do for nsDisplayOpacity. Same for the other container-style nsDisplayItem types: nsDisplayTransform, nsDisplayBlendMode, nsDisplayBlendContainer, nsDisplayMask, nsDisplayOwnLayer. These are already supported by our current layer system.
The only exception is nsDisplayFilter, which is a whole separate project.