1344027 - Get most of browser/components passing ESLint's no-undef rule

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Mark Banner (:standard8)]

I've got a couple of patches that get browser/components passing the no-undef rule save for three issues that are covered by other bugs.

Since they're quite big, and I'd like to be able to start working towards browser/content whilst waiting for those, I think now is a good time to land them.

The first one is to fixup the import-global-from option to allow circular references - browser/components/preferences is particularly bad at including multiple things different ways across files.

The second is the general fixes to browser/components to get the rule passing.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1344027 - Change the import-global-from option for eslint to allow circular references and resolve most of the no-undef issues in browser/components/preferences.

Review commit: https://reviewboard.mozilla.org/r/117064/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117064/

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1344027 - Add a places-overlay environment for ESLint for when placesOverlay.xul is included.

Review commit: https://reviewboard.mozilla.org/r/117066/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117066/

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1344027 - Move eslint-plugin-mozilla's .eslintrc.js file so that all of the plugin is linted, and fix the resulting issues.

Review commit: https://reviewboard.mozilla.org/r/117068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117068/

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1344027 - Fix most of the remaining ESLint no-undef issues in browser/components.

Review commit: https://reviewboard.mozilla.org/r/117070/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117070/

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8843266 [details]
Bug 1344027 - Fix most of the remaining ESLint no-undef issues in browser/components.

https://reviewboard.mozilla.org/r/117070/#review118742

Comment 6

[Dave Townsend [:mossop]]

Comment on attachment 8843263 [details]
Bug 1344027 - Change the import-global-from option for eslint to allow circular references and resolve most of the no-undef issues in browser/components/preferences.

https://reviewboard.mozilla.org/r/117064/#review118790

::: tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js:67
(Diff revision 1)
>  /**
> + * Global discovery can occasionally meet circular dependencies due to the way
> + * js files are included via xul files etc. This array is used to avoid getting
> + * into loops whilst the discovery is in progress.
> + */
> +var globalDiscoveryInProgressForFiles = [];

This could be a Set

::: tools/lint/eslint/eslint-plugin-mozilla/lib/globals.js:194
(Diff revision 1)
>      globalCache.set(path, globals);
>  
> +    let position = globalDiscoveryInProgressForFiles.indexOf(path);
> +    if (position != -1) {
> +      globalDiscoveryInProgressForFiles.splice(position, 1);
> +    }

Then this would be easier to do!

Comment 7

[Dave Townsend [:mossop]]

Comment on attachment 8843264 [details]
Bug 1344027 - Add a places-overlay environment for ESLint for when placesOverlay.xul is included.

https://reviewboard.mozilla.org/r/117066/#review118798

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 8843265 [details]
Bug 1344027 - Move eslint-plugin-mozilla's .eslintrc.js file so that all of the plugin is linted, and fix the resulting issues.

https://reviewboard.mozilla.org/r/117068/#review118800

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 8843263 [details]
Bug 1344027 - Change the import-global-from option for eslint to allow circular references and resolve most of the no-undef issues in browser/components/preferences.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117064/diff/1-2/

Comment 10

[Mark Banner (:standard8)]

Comment on attachment 8843264 [details]
Bug 1344027 - Add a places-overlay environment for ESLint for when placesOverlay.xul is included.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117066/diff/1-2/

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 8843265 [details]
Bug 1344027 - Move eslint-plugin-mozilla's .eslintrc.js file so that all of the plugin is linted, and fix the resulting issues.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117068/diff/1-2/

Comment 12

[Mark Banner (:standard8)]

Comment on attachment 8843266 [details]
Bug 1344027 - Fix most of the remaining ESLint no-undef issues in browser/components.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117070/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5cf23ffc1d0
Change the import-global-from option for eslint to allow circular references and resolve most of the no-undef issues in browser/components/preferences. r=mossop
https://hg.mozilla.org/integration/autoland/rev/bdd4e1f734a2
Add a places-overlay environment for ESLint for when placesOverlay.xul is included. r=mossop
https://hg.mozilla.org/integration/autoland/rev/feea1e54c19b
Move eslint-plugin-mozilla's .eslintrc.js file so that all of the plugin is linted, and fix the resulting issues. r=mossop
https://hg.mozilla.org/integration/autoland/rev/8947d02cec5d
Fix most of the remaining ESLint no-undef issues in browser/components. r=jaws

Comment 14

[Mark Banner (:standard8)]

Attachment: Follow-up to bug 1344027 - fix capitalisation of fontbuilder.js

This is a bustage fix for eslint - unfortunately running on Mac got away with the case sensitive issues of "fontbuilder.js" (not fontBuilder.js).

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/323e5db6b459
Follow-up to bug 1344027 - fix capitalisation of fontbuilder.js. rs=bustage-fix for eslint.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b5cf23ffc1d0
https://hg.mozilla.org/mozilla-central/rev/bdd4e1f734a2
https://hg.mozilla.org/mozilla-central/rev/feea1e54c19b
https://hg.mozilla.org/mozilla-central/rev/8947d02cec5d
https://hg.mozilla.org/mozilla-central/rev/323e5db6b459