Closed Bug 1344060 Opened 3 years ago Closed 3 years ago

Disable SHIELD system add-on on Beta and Release builds

Categories

(Firefox :: Normandy Client, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox53 --- fixed
firefox54 --- fixed

People

(Reporter: osmose, Assigned: osmose)

References

Details

Attachments

(1 file)

Since we're at risk of missing the QA signoff for 53 Aurora, we want to disable building the SHIELD system add-on on Beta and Release, and only include it built-in on Aurora and Nightly. Since we're already planning to use a system add-on update to ship to release on 52, we'll just do an update to beta before that as well, instead of riding the trains. That'll give QA and the dev team time to hammer out the test plan and bugfixes we need.

I've already run this by lizzard and ritu and they're down for it.
Attachment #8843120 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 8843120 [details]
Bug 1344060 - Only build the SHIELD system add-on on Nightly and Aurora.

https://reviewboard.mozilla.org/r/116886/#review118516
Attachment #8843120 - Flags: review+
Attachment #8843120 - Flags: review?(gijskruitbosch+bugs)
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e8a2f3d55415
Only build the SHIELD system add-on on Nightly and Aurora. r=mossop
Comment on attachment 8843120 [details]
Bug 1344060 - Only build the SHIELD system add-on on Nightly and Aurora.

Approval Request Comment
[Feature/Bug causing the regression]: Not applicable, we're disabling a system add-on that is about to ship to Beta from being activated on that channel.
[User impact if declined]: Users on Beta after the upcoming train merge will be running an incomplete system add-on. We won't be able to use the old self-repair system to send user surveys to them.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Just landed
[Needs manual test from QE? If yes, steps to reproduce]: Sort've. 

1. Open about:support.
2. Look for the "Shield Recipe Client" add-on in the Extensions list.

On Aurora and Nightly, it should be present (as it is currently), but on Beta and Release, it should not be present. There's not much to test until this change hits Beta.

[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: The mozconfig file that changes already has other add-ons that only ship to Nightly and Aurora, and the change simply moved the SHIELD add-on from one list to another.
[String changes made/needed]: None
Attachment #8843120 - Flags: approval-mozilla-aurora?
Comment on attachment 8843120 [details]
Bug 1344060 - Only build the SHIELD system add-on on Nightly and Aurora.

Turning this off for when 53 moves to beta.
Attachment #8843120 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/e8a2f3d55415
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Product: Shield → Firefox
You need to log in before you can comment on or make changes to this bug.