Closed Bug 1344155 Opened 6 years ago Closed 6 years ago

Remove toolbox in netmonitor

Categories

(DevTools :: Netmonitor, enhancement, P1)

Product:
DevTools
Component:
Netmonitor
Type:
enhancement

Tracking

(firefox54 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 54
Iteration:
54.3 - Mar 6
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: rickychien, Assigned: rickychien)

References

(Blocks 1 open bug)

Details

(Whiteboard: [netmonitor-reserve])

Attachments

(1 file)

Bug 1344155 - Remove toolbox in netmonitor
59 bytes, text/x-review-board-request
Honza
: review+
Details 
Remove toolbox in netmonitor, so that our codebase don't have to depend on it anymore.

* Remove toolbox in tabbar.js
* Remove all toolbox access in mochitest
Move small refactoring patch from bug 1308441 and remove toolbox as well.
Iteration: --- → 54.3 - Mar 6
Flags: qe-verify?
Priority: -- → P1
Whiteboard: [netmonitor][triage] → [netmonitor-reserve]
Comment on attachment 8843255 [details]
Bug 1344155 - Remove toolbox in netmonitor

https://reviewboard.mozilla.org/r/117050/#review118654

Nice work here!

R+ assuming try is green.

Honza
Attachment #8843255 - Flags: review?(odvarko) → review+
Pushed by rchien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0fc0b762b40a
Remove toolbox in netmonitor r=Honza
https://hg.mozilla.org/mozilla-central/rev/0fc0b762b40a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Flags: qe-verify? → qe-verify-
Depends on: 1392873
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.