1344214 - Status "waiting for download" does not contain the correct button in the pop-up

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P3)

Description

[CosminB]

Attachment: ActualResult.gif

[Affected versions]:
- Firefox 54.0a1 (2017-03-03) 
- Firefox 53.0a2 (20170303004003)

[Affected platforms]:
- Windows 7 64-bit
- Ubuntu 16.04 32-bit

[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Create extensions.webextPermissionPrompts and set it to true.
3.Create xpinstall.signatures.dev-root and set it to true.
4.Restart the browser
5.Install the following WebExtension: https://addons-dev.allizom.org/en-US/firefox/addon/permissionsall3/ and observe the pop-up while the WebExtension is downloaded.

[Expected results]:
- The pop-up has the “Add extension” button while downloading, as presented in the install flow https://www.screencast.com/t/BCoXAATvojP  

[Actual results]:
- The pop-up has the “Install” button while downloading. (please see attached gif)

[Additional notes]:
- This issue reproduces constantly.

Comment 1

[Andrew Swan [:aswan]]

Since that button never becomes active, is this something we care about?  Should the install/add button just be removed from the progress notification if we're going to shown permissions prompts?

Comment 2

[Markus Jaritz [:designakt] (UX)]

I agree with the [Expected result].
The idea of showing the install (now add) button already on the download dialog is that the downloading time can already count towards the delay that we have for this button. (If the download is instant you would still have to wait some time before the button would become active.) But if it is not instant, the download time counts towards that delay.
I would like us to keep that button and ensure that we always use the current string on that button.

Comment 3

[Andrew Swan [:aswan]]

Keep in mind that while we're downloading the xpi, we don't yet know if it is a webextension (for which we will show a permission notification with "Add") or something else (legacy extension, theme, language pack, etc. for which we may show the existing notification with "Install").  Is the request to change the button to "Add" and then have it change back to "Install" when it becomes active for non-webextensions?  That sounds weird to me...  Or is the request to change the existing prompt to say "Add"?  Or something else?

Comment 4

[Markus Jaritz [:designakt] (UX)]

(In reply to Andrew Swan [:aswan] from comment #3)
> Or is the request to change the existing prompt to say "Add"?

Yes. Please change all "Install" to "Add" to align with the new dialog. Thanks.

Comment 5

[Andrew Swan [:aswan]]

Attachment: Bug 1344214 Update button in addon install doorhanger

Review commit: https://reviewboard.mozilla.org/r/129630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129630/

Comment 6

[Francesco Lodolo [:flod]]

Comment on attachment 8857699 [details]
Bug 1344214 Update button in addon install doorhanger

https://reviewboard.mozilla.org/r/129630/#review132376

::: browser/locales/en-US/chrome/browser/browser.properties:164
(Diff revision 1)
>  addonDownloadVerifying=Verifying
>  
>  addonInstall.unsigned=(Unverified)
>  addonInstall.cancelButton.label=Cancel
>  addonInstall.cancelButton.accesskey=C
> -addonInstall.acceptButton.label=Install
> +addonInstall.acceptButton.label2=Add

Please use addonInstall.acceptButton2.label and addonInstall.acceptButton2.accesskey

Some tools try to match ID.label and ID.accesskey, so versioning the first part would be better.

Comment 7

[Andrew Swan [:aswan]]

Comment on attachment 8857699 [details]
Bug 1344214 Update button in addon install doorhanger

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/129630/diff/1-2/

Comment 8

[Francesco Lodolo [:flod]]

Comment on attachment 8857699 [details]
Bug 1344214 Update button in addon install doorhanger

https://reviewboard.mozilla.org/r/129630/#review132608

Looks good, thanks.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7d1429fe13f7
Update button in addon install doorhanger r=flod

Comment 10

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/7d1429fe13f7

Comment 11

[u589863]

Sorry if not the right bug,
This breaks installing of some ext,

https://downloads.adblockplus.org/devbuilds/adblockplusfirefox/adblockplusfirefox-1.13.2.1764.xpi

Door-hanger just closes w/o install/update option.

Comment 12

[Francesco Lodolo [:flod]]

Please file a new bug explaining what your issue is, what version of Firefox you're using, etc.. This bug only changed an existing string in the dialog. Also, I'm not the right person for a NI on this type of issues.

Comment 13

[CosminB]

Attachment: AddButton.gif

This issue is verified as fixed on Firefox 55.0a1 (2017-04-24) under Wind 7 64-bit, Ubuntu 16.04 32-bit and Mac OS X 10.10.4

The pop-up has the “Add” button while downloading.
Please see the attached file.