Created attachment 8843300 [details] [diff] [review] Patch In bug 1328140 I'll add megamorphic getter/setter IC stubs. These stubs will only tell IonBuilder the getter/setter JSFunction, so we need to refactor IonBuilder::testCommonGetterSetter a bit to work with that. I renamed objectsHaveCommonPrototype to commonPrototypeWithGetterSetter and changed it to look for a common prototype with the getter/setter property, instead of looking for the holder object. The patch also restructures getPropTryCommonGetter and setPropTryCommonSetter a bit so we can easily add an extra else-if branch in bug 1328140.
Attachment #8843300 - Flags: review?(bhackett1024)
Attachment #8843300 - Flags: review?(bhackett1024) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/0a826a2d310b Rewrite IonBuilder::testCommonGetterSetter to search for the holder instead of taking it as argument. r=bhackett
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.