1344221 - reader mode keyboard shortcut accel-(opt/alt)-r closes/crashes Firefox

Status: RESOLVED INVALID

(Firefox :: Untriaged, defect)

Description

[heinrichmartin]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

Pressed Ctrl+Alt+R on http://orf.at (no reader mode available)


Actual results:

Firefox closed or crashed


Expected results:

Nothing (optionally notify that the reader mode is not available)

Comment 1

[:Gijs (he/him)]

I can't reproduce. Can you provide more details, like a (submitted - click it to check it works!) crash report ID from about:crashes ? Does this happen on any website or only that one? Does it happen on a clean profile?

Comment 2

[heinrichmartin]

Sorry, my bad. It's https://addons.mozilla.org/de/firefox/addon/re-start/.
The weired thing is: this shortcut works on websites with reader mode available.

Two questions remain:
* Why did FF only shut down and not restart on Windows 10 (it restarts on Ctrl+Alt+R here on Windows 7)?
* How can I tell which feature takes precedence when the shortcuts conflict?

Comment 3

[:Gijs (he/him)]

(In reply to heinrichmartin from comment #2)
> Sorry, my bad. It's https://addons.mozilla.org/de/firefox/addon/re-start/.
> The weired thing is: this shortcut works on websites with reader mode
> available.
> 
> Two questions remain:
> * Why did FF only shut down and not restart on Windows 10 (it restarts on
> Ctrl+Alt+R here on Windows 7)?

I don't know. Checking crash reports would be a good idea. It's possible it's crashing on shutdown and that's why it's failing to restart.

> * How can I tell which feature takes precedence when the shortcuts conflict?

You can't because of how shortcuts / XUL add-ons work, which is yet another reason we're switching to web extensions. The add-on description says the shortcut it uses is configurable, though, so you could just avoid the conflict that way.

Comment 4

[heinrichmartin]

(In reply to :Gijs from comment #3)
> (In reply to heinrichmartin from comment #2)
> > * Why did FF only shut down and not restart on Windows 10 (it restarts on
> > Ctrl+Alt+R here on Windows 7)?
> 
> I don't know. Checking crash reports would be a good idea. It's possible
> it's crashing on shutdown and that's why it's failing to restart.

Unfortunately, I cannot reproduce this. Should have investigated immediately...

> > * How can I tell which feature takes precedence when the shortcuts conflict?
> 
> You can't because of how shortcuts / XUL add-ons work, which is yet another
> reason we're switching to web extensions. The add-on description says the
> shortcut it uses is configurable, though, so you could just avoid the
> conflict that way.

At least this gives an interpretation to my ticket. It is odd that the browser restarts on Ctrl+Alt+R if and only if reader mode is not available.

I did a quick ticket search for "shortcut web extensions", but eventually I did not link this ticket to any of them (this is just one use case).

:Gijs thank you for looking at it!