1344276 - Make sample list of top 20 websites (of www.alexa.com/topsites) for autocomlete prefill

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement)

Comment 1

[Svetlana Orlik]

Attachment: Bug 1344276 - top 20 websites of www.alexa.com/topsites,

Review commit: https://reviewboard.mozilla.org/r/117114/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117114/

Comment 2

[Marco Bonardo [:mak]]

For en-US you probably want to use this list http://www.alexa.com/topsites/countries/US rather than the world wide one.

Comment 3

[:Gijs (he/him)]

(In reply to Marco Bonardo [::mak] from comment #2)
> For en-US you probably want to use this list
> http://www.alexa.com/topsites/countries/US rather than the world wide one.

Yes, but right now there's no region/language-specific support at all, so this list (given we're using it for builds in any language and any region) seems strictly better than the current one. We should probably look at region/locale-based lists, but for now, I think this works.

Comment 4

[:Gijs (he/him)]

Comment on attachment 8843350 [details]
Bug 1344276 - top 20 websites of www.alexa.com/topsites,

https://reviewboard.mozilla.org/r/117114/#review119156

Let's do this for now and switch to localized content later.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9762f34b30a4
top 20 websites of www.alexa.com/topsites, r=Gijs

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9762f34b30a4

Comment 7

[Andrei Vaida [:avaida]]

Should manual QA be looking at this?

Comment 8

[:Gijs (he/him)]

(In reply to Andrei Vaida [:avaida], Desktop Release QA – please ni? me from comment #7)
> Should manual QA be looking at this?

It's preffed off and landed 3 months ago, so unless something changed, I don't think so? Was there activity in other bugs that's not obvious here?

Comment 9

[Andrei Vaida [:avaida]]

I'm not aware of changes or activity linked to this fix. I'll trust your judgement here.