Closed Bug 1344307 Opened 3 years ago Closed 3 years ago

Clean up lightweight theme footer handling

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 54
Tracking Status
firefox54 --- fixed

People

(Reporter: dao, Assigned: dao)

References

Details

Attachments

(1 file)

Since the lightweight theme footer is using CSS variables, LightweightThemeConsumer.jsm doesn't need to know anymore which element is used as the footer, so browser.xul can stop communicating that.

FWIW, I'm not even sure that we put anything transparent in browser-bottombox these days that would allow the footer image to be visible at all.
Comment on attachment 8843387 [details]
Bug 1344307 - Clean up lightweight theme footer handling.

https://reviewboard.mozilla.org/r/117146/#review118772

Thanks, I couldn't get a footer to show up in my testing either but I thought maybe it was related to the themes I were testing with.

::: browser/base/content/browser.css:458
(Diff revision 1)
>  
> -#browser-bottombox[lwthemefooter="true"] {
> +:root[lwthemefooter=true] #browser-bottombox:-moz-lwtheme {
>    background-repeat: no-repeat;
>    background-position: bottom left;
>    background-color: var(--lwt-accent-color);
> -  background-image: var(--lwt-header-image);
> +  background-image: var(--lwt-footer-image);

Thanks for catching this!
Attachment #8843387 - Flags: review?(jaws) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e5b4f79727c8
Clean up lightweight theme footer handling. r=jaws
https://hg.mozilla.org/mozilla-central/rev/e5b4f79727c8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
You need to log in before you can comment on or make changes to this bug.