Closed Bug 1344356 Opened 7 years ago Closed 7 years ago

-Wunused-lambda-capture build warnings in gfx code

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: dholbert, Assigned: rhunt)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

clang trunk has added a new build warning "-Wunused-lambda-capture" for variables captured by lambda functions & then unused.

Filing this bug for 2 instances in gfx/layers code:
gfx/layers/composite/AsyncCompositionManager.cpp:809:15 [-Wunused-lambda-capture] lambda capture 'aOutFoundRoot' is not used

gfx/layers/ipc/CompositorBridgeParent.cpp:469:31 [-Wunused-lambda-capture] lambda capture 'this' is not use
}
Attached patch fix-unused.patchSplinter Review
Attachment #8844016 - Flags: review?(bugmail)
Assignee: nobody → rhunt
Whiteboard: [gfx-noted]
Comment on attachment 8844016 [details] [diff] [review]
fix-unused.patch

Review of attachment 8844016 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Make sure to put the bug number in the commit message.
Attachment #8844016 - Flags: review?(bugmail) → review+
Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60b5be6bc57d
Fix unused lambda capture warnings r=kats
https://hg.mozilla.org/mozilla-central/rev/60b5be6bc57d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: