Build display lists directly instead of using an intermediate representation

RESOLVED FIXED in mozilla55

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This make us build display lists directly instead of through the now pointless IPC goop.
(Assignee)

Updated

a year ago
Depends on: 1341064
(Assignee)

Comment 1

a year ago
Created attachment 8843500 [details] [diff] [review]
Build the display lists directly

This is a largely uninteresting patch that just uses the DisplayListBuilder directly. A wonderful cleanup patch will come after this. One of the more interesting pieces is the use of PushBuiltDisplayList. This is needed for handling empty transactions. See https://github.com/servo/webrender/pull/934 for more info.

I'll take the first review that I can get.
Attachment #8843500 - Flags: review?(rhunt)
Attachment #8843500 - Flags: review?(nical.bugzilla)
Attachment #8843500 - Flags: review?(bugmail)
Attachment #8843500 - Attachment is patch: true
Comment on attachment 8843500 [details] [diff] [review]
Build the display lists directly

Review of attachment 8843500 [details] [diff] [review]:
-----------------------------------------------------------------

Remove the commented-out mCommands in WebRenderDisplayItemLayer.h. Also at some point we'll want to rename all the CreateWebRenderCommand functions but i guess we can wait until the dust settles.
Attachment #8843500 - Flags: review?(rhunt)
Attachment #8843500 - Flags: review?(nical.bugzilla)
Attachment #8843500 - Flags: review?(bugmail)
Attachment #8843500 - Flags: review+
Assignee: nobody → jmuizelaar

Comment 3

a year ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/0d411df025f5
Build the display lists directly. r=kats
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.