1344402 - Remove "Your try syntax would not trigger any jobs" from try hook

Status: ASSIGNED

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

(sandbox) dustin@lamport ~/p/m-c (bug1337903) $ hg push-to-try -m 'try: -b o -p none -t none -u none'
Creating temporary commit for remote...
pushing to ssh://hg.mozilla.org/try
searching for changes
remote: adding changesets                                                                                                                                                                                                                      
remote: adding manifests
remote: adding file changes
remote: added 3 changesets with 18 changes to 17 files (+1 heads)
remote: 
remote: ***************************** ERROR ******************************
remote: Your try syntax would not trigger any jobs. Either specify a build
remote: with '-p' or an arbitrary job with '-j'. If you intended to push
remote: without triggering any jobs, omit the try syntax completely. For
remote: assistance with try server, see https://wiki.mozilla.org/Try.
remote: ******************************************************************

when in fact that syntax will potentially generate 30 jobs as of the current tip.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Curious what this should be changed to. Remove that error entirely? Change it to a warning and tweak the message, but let the push go through?

If we change the message, what should it be changed to? "Your try syntax would not necessarily trigger any desktop/mobile build jobs."?

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Letting the push go through while still printing the error is just dropping this line: https://dxr.mozilla.org/hgcustom_version-control-tools/rev/6a20a18a2d58b167d2180f6604866b4149bba5c2/hghooks/mozhghooks/try_warning.py#42

Comment 3

[Gregory Szorc [:gps]]

I think we should remove this error message altogether and move the validation to `mach try`. Embedding business logic like this on the Mercurial server where it is distant from the code dictating behavior is not a good idea because it will drift out of sync with try scheduling reality.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

*nod*

Comment 6

[Charlotte Wilson [:cswilson252]]

Attachment: hooks: Leave job trigger checking to mach (Bug 1344402); r=jcristau!