1344402 - Remove "Your try syntax would not trigger any jobs" from try hook

Status: NEW

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

(sandbox) dustin@lamport ~/p/m-c (bug1337903) $ hg push-to-try -m 'try: -b o -p none -t none -u none'
Creating temporary commit for remote...
pushing to ssh://hg.mozilla.org/try
searching for changes
remote: adding changesets                                                                                                                                                                                                                      
remote: adding manifests
remote: adding file changes
remote: added 3 changesets with 18 changes to 17 files (+1 heads)
remote: 
remote: ***************************** ERROR ******************************
remote: Your try syntax would not trigger any jobs. Either specify a build
remote: with '-p' or an arbitrary job with '-j'. If you intended to push
remote: without triggering any jobs, omit the try syntax completely. For
remote: assistance with try server, see https://wiki.mozilla.org/Try.
remote: ******************************************************************

when in fact that syntax will potentially generate 30 jobs as of the current tip.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Curious what this should be changed to. Remove that error entirely? Change it to a warning and tweak the message, but let the push go through?

If we change the message, what should it be changed to? "Your try syntax would not necessarily trigger any desktop/mobile build jobs."?

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Letting the push go through while still printing the error is just dropping this line: https://dxr.mozilla.org/hgcustom_version-control-tools/rev/6a20a18a2d58b167d2180f6604866b4149bba5c2/hghooks/mozhghooks/try_warning.py#42

Comment 3

[Gregory Szorc [:gps]]

I think we should remove this error message altogether and move the validation to `mach try`. Embedding business logic like this on the Mercurial server where it is distant from the code dictating behavior is not a good idea because it will drift out of sync with try scheduling reality.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

*nod*

Comment 5

[alexsubi1337]

It seems like there is an issue with the syntax you used for the hg push-to-try command. The error message indicates that the specified try syntax would not trigger any jobs, and it suggests that you either specify a build with -p or an arbitrary job with -j. The error message also mentions that if you intended to push without triggering any jobs, you should omit the try syntax completely by https://(spam)/.

In your case, you mentioned that you used the following try syntax:
-b o -p none -t none -u none
This syntax seems to be specifying -p none, which means no platforms, and -t none, which means no tests. The error message suggests that this combination might not trigger any jobs. If you intend to trigger jobs, you may need to adjust the syntax.

Without knowing the specific requirements for your project, it's challenging to provide an exact fix, but you might want to ensure that you are specifying valid options for platforms (-p), tests (-t), and builds (-b). If you are trying to trigger jobs, you may need to include information that would result in actual jobs being scheduled.

For example, you might consider specifying a platform, tests, or builds to trigger the desired jobs. Here's an example:
hg push-to-try -m 'try: -b do -p linux -u all -t all'
This example specifies building for Linux (-p linux), running all tests (-t all), and using the default build (-b do). Adjust the options based on your project's requirements.

If you still face issues, you may want to refer to the Mozilla Try Server documentation or seek assistance from the Mozilla community to ensure that your try syntax is correct and aligns with the current configuration of the Try Server.