1344448 - nsLiteralString can be reassigned

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

I saw some code like this today during a review:

  auto foo = NS_LITERAL_STRING("bar");
  if (something) {
    foo = NS_LITERAL_STRING("baz");
  }

OK, so "auto" is evil an even though the RHS is explicitly typed as "const nsLiteralString&" it declares "foo' as "nsLiteralString" (I assume...  I don't know how to check).  But I'm still not thrilled that assignment works.

Comment 1

[(Away)]

I'll fix this as part of bug 1344629.

> OK, so "auto" is evil an even though the RHS is explicitly typed as "const
> nsLiteralString&" it declares "foo' as "nsLiteralString" (I assume...  I
> don't know how to check).

Yup.

void whatType(float f) {}
whatType(foo);

error C2664: 'void whatType(float)': cannot convert argument 1 from 'nsLiteralString' to 'float'

Comment 2

[(Away)]

As part of bug 1344629 I deleted operator=.