1344529 - unused variable error in widget/gtk/gtk2drawing.c: 1812 : arrow_size

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Edmund Wong (:ewong)]

During building of 2.48b1, and if assuming the patch from
bug 1343781 is accepted, we'll encounter this error:

In file included from /builds/slave/rel-c-beta-lnx-bld/build/objdir/widget/gtk/Unified_c_widget_gtk0.c:2:0:
4500 /builds/slave/rel-c-beta-lnx-bld/build/mozilla/widget/gtk/gtk2drawing.c: In function 'moz_gtk_combo_box_paint':
4501 /builds/slave/rel-c-beta-lnx-bld/build/mozilla/widget/gtk/gtk2drawing.c:1812:10: error: unused variable 'arrow_size' [-Werror=unused-variable]
4502      gint arrow_size, separator_width;
4503           ^
4504 cc1: all warnings being treated as errors
4505 make[4]: *** [Unified_c_widget_gtk0.o] Error 1
4506 make[4]: Leaving directory `/builds/slave/rel-c-beta-lnx-bld/build/objdir/widget/gtk'
4507 make[3]: *** [widget/gtk/target] Error 2
4508 make[3]: *** Waiting for unfinished jobs....

Comment 1

[Edmund Wong (:ewong)]

Attachment: proposed patch

proposed patch.

Comment 2

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8843672 [details] [diff] [review]
proposed patch

Its even the same in c-c and the variable is clearly unused here.

Comment 3

[Frank-Rainer Grahl (:frg)]

r+ for SeaMonkey beta/release branch only.

Comment 4

[Edmund Wong (:ewong)]

since this is going into a relbranch, I'm moving it back to SM's build config
and filing a bug against the core:widget.

Comment 5

[Edmund Wong (:ewong)]

Pushed to m-b's relbranch SEA248b1_2017021701_RELBRANCH
https://hg.mozilla.org/releases/mozilla-beta/rev/de7fd89731ccef938833a606c074f6796a59e8a5