Closed
Bug 1344529
Opened 8 years ago
Closed 8 years ago
unused variable error in widget/gtk/gtk2drawing.c: 1812 : arrow_size
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.48
People
(Reporter: ewong, Assigned: ewong)
References
Details
Attachments
(1 file)
905 bytes,
patch
|
frg
:
review+
|
Details | Diff | Splinter Review |
During building of 2.48b1, and if assuming the patch from
bug 1343781 is accepted, we'll encounter this error:
In file included from /builds/slave/rel-c-beta-lnx-bld/build/objdir/widget/gtk/Unified_c_widget_gtk0.c:2:0:
4500 /builds/slave/rel-c-beta-lnx-bld/build/mozilla/widget/gtk/gtk2drawing.c: In function 'moz_gtk_combo_box_paint':
4501 /builds/slave/rel-c-beta-lnx-bld/build/mozilla/widget/gtk/gtk2drawing.c:1812:10: error: unused variable 'arrow_size' [-Werror=unused-variable]
4502 gint arrow_size, separator_width;
4503 ^
4504 cc1: all warnings being treated as errors
4505 make[4]: *** [Unified_c_widget_gtk0.o] Error 1
4506 make[4]: Leaving directory `/builds/slave/rel-c-beta-lnx-bld/build/objdir/widget/gtk'
4507 make[3]: *** [widget/gtk/target] Error 2
4508 make[3]: *** Waiting for unfinished jobs....
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•8 years ago
|
||
proposed patch.
Assignee | ||
Updated•8 years ago
|
Component: Build Config → Widget: Gtk
Product: SeaMonkey → Core
Version: SeaMonkey 2.48 Branch → 51 Branch
Comment 2•8 years ago
|
||
Comment on attachment 8843672 [details] [diff] [review]
proposed patch
Its even the same in c-c and the variable is clearly unused here.
Attachment #8843672 -
Flags: review+
Comment 3•8 years ago
|
||
r+ for SeaMonkey beta/release branch only.
Assignee | ||
Updated•8 years ago
|
Component: Widget: Gtk → Build Config
Product: Core → SeaMonkey
Version: 51 Branch → SeaMonkey 2.48 Branch
Assignee | ||
Comment 4•8 years ago
|
||
since this is going into a relbranch, I'm moving it back to SM's build config
and filing a bug against the core:widget.
Assignee | ||
Comment 5•8 years ago
|
||
Pushed to m-b's relbranch SEA248b1_2017021701_RELBRANCH
https://hg.mozilla.org/releases/mozilla-beta/rev/de7fd89731ccef938833a606c074f6796a59e8a5
Assignee: nobody → ewong
Target Milestone: --- → seamonkey2.48
Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•