nsTSubstring::Split should be a const method

RESOLVED FIXED in Firefox 55

Status

()

Core
String
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
As nsTSubstring::Split doesn't actually modify the target string -- it just identifies ranges within it -- we can declare it as a const method.

(This is wanted for methods in bug 1337694, where we'd like to be able to apply Split to strings passed in const& parameters.)
(Assignee)

Comment 1

9 months ago
Created attachment 8843707 [details] [diff] [review]
Make nsTSubstring::Split a const method
Attachment #8843707 - Flags: review?(gpascutto)
(Assignee)

Updated

9 months ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8843707 - Flags: review?(gpascutto) → review+
(Assignee)

Comment 2

9 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/528fdb775b6355bc176ea650770d56ad162f7cc5
Bug 1344555 - Make nsTSubstring::Split a const method. r=gcp

Comment 3

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/528fdb775b63
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.