Closed
Bug 1344555
Opened 8 years ago
Closed 8 years ago
nsTSubstring::Split should be a const method
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(1 file)
|
1.69 KB,
patch
|
gcp
:
review+
|
Details | Diff | Splinter Review |
As nsTSubstring::Split doesn't actually modify the target string -- it just identifies ranges within it -- we can declare it as a const method.
(This is wanted for methods in bug 1337694, where we'd like to be able to apply Split to strings passed in const& parameters.)
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8843707 -
Flags: review?(gpascutto)
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
|
||
Updated•8 years ago
|
Attachment #8843707 -
Flags: review?(gpascutto) → review+
|
|
Assignee | |
Comment 2•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/528fdb775b6355bc176ea650770d56ad162f7cc5
Bug 1344555 - Make nsTSubstring::Split a const method. r=gcp
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•4 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•