Closed Bug 1344555 Opened 6 years ago Closed 6 years ago

nsTSubstring::Split should be a const method

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

References

Details

Attachments

(1 file)

As nsTSubstring::Split doesn't actually modify the target string -- it just identifies ranges within it -- we can declare it as a const method.

(This is wanted for methods in bug 1337694, where we'd like to be able to apply Split to strings passed in const& parameters.)
Attachment #8843707 - Flags: review?(gpascutto)
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8843707 - Flags: review?(gpascutto) → review+
https://hg.mozilla.org/mozilla-central/rev/528fdb775b63
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: String → XPCOM
You need to log in before you can comment on or make changes to this bug.