1344574 - Dropdown menu list is completely unreadable due to broken style caused by patches from bug #910022

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

STR:
1. Open this URL - https://www.redisbad.pl/app_fiscal.php/husaria-szarza-nadruk-sublimacyjny
2. Select one of two dropdown buttons to see dropdown menu list
3. and see that it's mostly unreadable due to broken style

either there should be:
-normal system style like black text fonts and white background (like in Firefox 53)
-normal website style like white text fonts and black background (fixing current state + with dropdown button

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug - Fx 53.0a2.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug - Fx 54.0a1.png

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Virtual_ManPL [:Virtual] - (ni? me) from comment #0)
> + with dropdown button style
fixed

Comment 4

[Marcia Knous [:marcia]]

Tracking 54+ for this visible regression.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

I've got a patch that should fix this. Just need to finish writing the new test.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1344574 - Compare the option foreground color to the used select background color instead of just the user-agent default select background color.

Review commit: https://reviewboard.mozilla.org/r/117656/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117656/

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 8

[Marcia Knous [:marcia]]

Tracking 55+ for this regression.

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8844119 [details]
Bug 1344574 - Compare the option foreground color to the used select background color instead of just the user-agent default select background color.

https://reviewboard.mozilla.org/r/117656/#review119816

Thanks! Don't forget to get your uplift requested.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9011255607e3
Compare the option foreground color to the used select background color instead of just the user-agent default select background color. r=mconley

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8844119 [details]
Bug 1344574 - Compare the option foreground color to the used select background color instead of just the user-agent default select background color.

Approval Request Comment
[Feature/Bug causing the regression]: missed a case as part of bug 910022
[User impact if declined]: <select> menus on some pages may be unreadable
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: just landed on autoland, should be in Nightly within 2 days
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no, simple fix covered by tests
[Why is the change risky/not risky?]: see above answer
[String changes made/needed]: none

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9011255607e3

Comment 13

[Gerry Chang [:gchang]]

Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!

Comment 14

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

@ Gerry Chang [:gchang] - No need to, as reporter of this issue, I will do it. ;)

Comment 15

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm marking this bug as VERIFIED,
because starting from Mozilla Firefox Nightly 55.0a1 (2017-03-09) the issue is fixed.

Comment 16

[Gerry Chang [:gchang]]

Comment on attachment 8844119 [details]
Bug 1344574 - Compare the option foreground color to the used select background color instead of just the user-agent default select background color.

Fix a unreadable dropdown menu regression and was verified. Aurora54+.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/97b3de3b6c3e