1344576 - Gecko Profiler with JavaScript enabled in Features crashing Mozilla Firefox in [@ mozilla::Maybe<T>::emplace<T> ] & [@ JSRuntime::beginSingleThreadedExecution ] & [@ ThreadInfo::StreamSamplesAndMarkers ]

Status: VERIFIED WORKSFORME

(Core :: Gecko Profiler, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Gecko Profiler 2.0.31 with these settings:
- Interval = 100ms
- Buffer size = 90kB
- Threads = ,
- Features = Stack walk, JavaScript, Task tracer

STR:
1. Go to this URL - https://www.youtube.com/watch?v=2vjPBrBU-TM
2. Start catching the profile by Ctrl+Shift+1 keyboard shortcut
3. Stop catching the profile by Ctrl+Shift+2 keyboard shortcut
4. Enjoy the crash...

Crashlog report (doubled each crash) [@ mozilla::Maybe<T>::emplace<T> ]:
https://crash-stats.mozilla.com/report/index/656f584c-f4ff-416d-bd89-eb9982170302
https://crash-stats.mozilla.com/report/index/d6344d7d-56ad-409f-b50c-17add2170302
https://crash-stats.mozilla.com/report/index/2f4aa3d1-8763-4d14-a1c4-06bde2170302
https://crash-stats.mozilla.com/report/index/d8748bdf-e89f-4657-96be-486c22170302
https://crash-stats.mozilla.com/report/index/38fa3117-3db9-4849-b022-10e0f2170302
https://crash-stats.mozilla.com/report/index/c8890cea-78a4-4df0-9f9f-23a462170302
https://crash-stats.mozilla.com/report/index/0ff1ada6-52eb-4ea9-868f-199852170302
https://crash-stats.mozilla.com/report/index/975065fa-8396-4185-8b4c-a6b7f2170305
https://crash-stats.mozilla.com/report/index/3b6c7bd4-b49e-4118-a70a-e21da2170305
https://crash-stats.mozilla.com/report/index/3788780f-10bd-4f35-8c75-75a312170305
https://crash-stats.mozilla.com/report/index/306d5971-3139-43b1-8f34-3a1952170305

Crashlog report (doubled each crash) [@ JSRuntime::beginSingleThreadedExecution ]:
https://crash-stats.mozilla.com/report/index/f78a9a4a-24de-48a8-abee-350dd2170303
https://crash-stats.mozilla.com/report/index/a3d883f9-edc4-4414-9aee-b45072170303
https://crash-stats.mozilla.com/report/index/3ac0ac80-a4f8-4d90-9347-2a4582170305
https://crash-stats.mozilla.com/report/index/d32902bd-6d05-482a-a3ad-86d432170305

Crashlog report (doubled each crash) [@ ThreadInfo::StreamSamplesAndMarkers ]:
https://crash-stats.mozilla.com/report/index/6a47300e-60c5-4171-b47f-b23532170305
https://crash-stats.mozilla.com/report/index/28fecbf2-b3a5-4bfc-a71f-c50dd2170305

Comment 1

[(no longer active)]

I also hit this: bp-2cfb70ba-612d-48c9-8c26-285172170306

Comment 2

[(no longer active)]

Markus, can you please take a look?  Thanks!

Comment 3

[Markus Stange [:mstange]]

Julian, is this covered by the crashes you're looking into?

Comment 4

[Julian Seward [:jseward]]

Markus, the mozilla::Maybe<T>::emplace<T> crash is one I've seen quite
a bit recently whilst testing the profiler.  I'm not sure if it's already
filed.  I'll check.  We have a number of stuff-ran-on-the-wrong-thread
bugs with the profiler, and this is one of them.

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Julian Seward [:jseward] from comment #4)
> Markus, the mozilla::Maybe<T>::emplace<T> crash is one I've seen quite
> a bit recently whilst testing the profiler.  I'm not sure if it's already
> filed.  I'll check.  We have a number of stuff-ran-on-the-wrong-thread
> bugs with the profiler, and this is one of them.

The bug about [@ mozilla::Maybe<T>::emplace<T> ] crash only is in bug #1224595,
but mine crashing randomly with all these 3 crashlogs signatures.

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

No crashes on Firefox 56 and later, so I'm marking this bug as FIXED.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Without a known fix, WFM is the correct resolution.