1344585 - test_tls_server.js leaks some objects

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[(no longer active)]

STR:

$ XPCOM_MEM_LEAK_LOG=1 ./mach xpcshell-test netwerk/test/unit/test_tls_server.js
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "== BloatView: ALL (cumulative) LEAK STATISTICS, default process 67063"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "     |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "     |                                      | Per-Inst   Leaked|   Total      Rem|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "   0 |TOTAL                                 |       56    14394|   27373      164|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "   6 |BackstagePass                         |      104      104|      13        1|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  16 |CancelableRunnable                    |       48      192|     135        4|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  22 |CondVar                               |       40       80|     110        2|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  39 |IdlePeriod                            |       24       24|      39        1|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  51 |Mutex                                 |       32      544|     326       17|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  55 |PollableEvent                         |       24       24|       1        1|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  66 |ReentrantMonitor                      |       40      240|      77        6|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  72 |Runnable                              |       40      160|     762        4|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  82 |StringAdopt                           |        1        2|     432        2|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  84 |TLSServerConnectionInfo               |      128      256|      12        2|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  85 |TLSServerSecurityObserverProxy        |       32       64|      12        2|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  86 |TLSServerSocket                       |      240      480|      12        2|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) "  93 |TransportSecurityInfo                 |      280      560|      12        2|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) " 101 |XPCNativeInterface                    |       56      560|      71       10|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) " 102 |XPCNativeMember                       |       16      160|    2013       10|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) " 103 |XPCNativeSet                          |       32      192|     161        6|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) " 104 |XPCWrappedNative                      |       96      576|     775        6|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) " 105 |XPCWrappedNativeProto                 |       40      240|     188        6|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) " 107 |XPCWrappedNativeTearOff               |       32      224|     990        7|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) " 114 |nsAStreamCopier                       |      176      704|      58        4|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) " 135 |nsDNSRecord                           |       48       96|      12        2|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) " 153 |nsHostRecord                          |      176      176|       1        1|"
 0:06.70 PROCESS_OUTPUT: Thread-1 (pid:67063) " 170 |nsJSPrincipals                        |       24       24|       4        1|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 177 |nsMainThreadPtrHolder<T>              |       24       48|      26        2|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 180 |nsNSSCertList                         |       56      112|      12        2|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 181 |nsNSSCertificate                      |       72      216|      21        3|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 185 |nsNSSSocketInfo                       |      408      816|      12        2|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 196 |nsPipe                                |      208     1248|      48        6|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 197 |nsPipeInputStream                     |      136      816|      48        6|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 205 |nsSSLStatus                           |       64      128|      12        2|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 210 |nsServerSocket                        |      224      448|      12        2|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 214 |nsSocketTransport                     |      760     3040|      24        4|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 215 |nsSocketTransportService              |      256      256|       1        1|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 220 |nsStringBuffer                        |        8       40|    8260        5|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 226 |nsTArray_base                         |        8       88|    6233       11|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 227 |nsThread                              |      352      352|      38        1|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 247 |nsXPCWrappedJS                        |      120      480|      77        4|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 248 |nsXPCWrappedJSClass                   |       72      144|      35        2|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) " 258 |xptiInterfaceInfo                     |       40      480|      98       12|"
 0:06.71 PROCESS_OUTPUT: Thread-1 (pid:67063) "nsTraceRefcnt::DumpStatistics: 259 entries"

Comment 1

[Patrick McManus [:mcmanus]]

want to take this on too?

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: bug 1344585 - close streams and server sockets in test_tls_server.js to prevent leaks

Review commit: https://reviewboard.mozilla.org/r/122474/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122474/

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Pretty similar to bug 1344584 - some streams and the server sockets needed to be closed.

Comment 4

[Patrick McManus [:mcmanus]]

Comment on attachment 8849700 [details]
bug 1344585 - close streams and server sockets in test_tls_server.js to prevent leaks

https://reviewboard.mozilla.org/r/122474/#review124888

thanks!

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=071849e7e71be334b7181191695d5aafeeda843d

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3afc4f01b90
close streams and server sockets in test_tls_server.js to prevent leaks r=mcmanus

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e3afc4f01b90