1344589 - test_searchSuggest.js leaks some objects

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[(no longer active)]

STR:

$ XPCOM_MEM_LEAK_LOG=1 ./mach xpcshell-test toolkit/components/search/tests/xpcshell/test_searchSuggest.js

 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) "== BloatView: ALL (cumulative) LEAK STATISTICS, default process 67613"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) "     |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) "     |                                      | Per-Inst   Leaked|   Total      Rem|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) "   0 |TOTAL                                 |       51     1808|  161170       15|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) "  40 |CancelableRunnable                    |       48       48|     639        1|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 111 |Mutex                                 |       32       96|     896        3|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 125 |PollableEvent                         |       24       24|       1        1|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 141 |ReentrantMonitor                      |       40       40|     325        1|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 152 |Runnable                              |       40       40|    3238        1|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 241 |nsAStreamCopier                       |      176      176|      71        1|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 371 |nsPipe                                |      208      208|     187        1|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 372 |nsPipeInputStream                     |      136      136|     187        1|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 399 |nsSocketTransport                     |      760      760|      59        1|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 400 |nsSocketTransportService              |      256      256|       1        1|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 409 |nsStringBuffer                        |        8        8|   28820        1|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) " 417 |nsTArray_base                         |        8       16|   45090        2|"
 0:45.80 PROCESS_OUTPUT: Thread-1 (pid:67613) "nsTraceRefcnt::DumpStatistics: 471 entries"

Comment 1

[(no longer active)]

The leaking subtest is slow_timeout: <http://searchfox.org/mozilla-central/rev/e844f7b79d6c14f45478dc9ea1d7f7f82f94fba6/toolkit/components/search/tests/xpcshell/test_searchSuggest.js#416>.

Matt, any chance you could help with this please?

Comment 2

[Matthew N. [:MattN]]

This looks to be leaking Necko stuff because slow_timeout doesn't cleanup the slow XHR request. This is probably fixable by calling controller.stop() at the right time. I'll take a look when my debug build finishes.

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1344589 - Wait for the httpServer to shutdown in head_search.js to avoid reported leaks.

The test slow_timeout in test_searchSuggest.js was keeping a request open for 10s so the server wouldn't stop immediately.

Review commit: https://reviewboard.mozilla.org/r/118430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118430/

Comment 4

[Matthew N. [:MattN]]

After the fix I still see the following but I'm guessing that's a separate issue:

> == BloatView: ALL (cumulative) LEAK STATISTICS, default process 69576
>      |<----------------Class--------------->|<-----Bytes------>|<----Objects---->|
>      |                                      | Per-Inst   Leaked|   Total      Rem|
>    0 |TOTAL                                 |       51        8|  161407        1|
>  416 |nsTArray_base                         |        8        8|   45147        1|
> nsTraceRefcnt::DumpStatistics: 470 entries"

Comment 5

[Drew Willcoxon :adw]

Comment on attachment 8845239 [details]
Bug 1344589 - Wait for the httpServer to shutdown in head_search.js to avoid reported leaks.

https://reviewboard.mozilla.org/r/118430/#review120772

LGTM

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4aa128f4b262
Wait for the httpServer to shutdown in head_search.js to avoid reported leaks. r=adw

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4aa128f4b262