1344603 - Make StopAnimationsForElement() and StopTransitionsForElement() as a member function of CommonAnimationManager

Status: RESOLVED FIXED

(Core :: DOM: Animation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

Actually I was also trying to move mEventDispatcher and related function to this mEventDispatcher into CommonAnimationManager but gave up. That's because it requires NS_IMPL_CYCLE_COLLECTION macro (and two more macrso), I did not come up with an easy way to use the macros for CommonAnimationManager.
I hope someone tries it in other bug.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1344603 - Make Stop{Animations|Transitions}ForElement as a member function of CommonAnimationManager.

Review commit: https://reviewboard.mozilla.org/r/117422/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117422/

Comment 2

[Hiroyuki Ikezoe (:hiro)]

I did use StopAnimationsForElement for the new member function here.  I initially use StopForElement() but it's little bit vague, so I did insert 'Animations' as a common word for CSS animations and transitions.
Brian, what do you think about the name?

Comment 3

[Brian Birtles (:birtles)]

Seems fine to me.

Comment 4

[Boris Chiou [:boris]]

Comment on attachment 8843819 [details]
Bug 1344603 - Make Stop{Animations|Transitions}ForElement as a member function of CommonAnimationManager.

https://reviewboard.mozilla.org/r/117422/#review119046

LGTM

Comment 5

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbb3fe956d91e9c5aaa459bdc9eea367b654439a

Comment 6

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s a5919d62c823 -d 26cf91f36f5e: rebasing 379572:a5919d62c823 "Bug 1344603 - Make Stop{Animations|Transitions}ForElement as a member function of CommonAnimationManager. r=boris" (tip)
merging layout/base/RestyleManager.cpp
merging layout/style/nsAnimationManager.cpp
merging layout/style/nsAnimationManager.h
warning: conflicts while merging layout/style/nsAnimationManager.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Thank you autoland! I am surprised that you had the ability to notify us when you could not merge commits.

Comment 8

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8843819 [details]
Bug 1344603 - Make Stop{Animations|Transitions}ForElement as a member function of CommonAnimationManager.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117422/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/911024a9cf3c
Make Stop{Animations|Transitions}ForElement as a member function of CommonAnimationManager. r=boris

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/911024a9cf3c