Make StopAnimationsForElement() and StopTransitionsForElement() as a member function of CommonAnimationManager

RESOLVED FIXED in Firefox 54

Status

()

Core
DOM: Animation
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

11 months ago
Actually I was also trying to move mEventDispatcher and related function to this mEventDispatcher into CommonAnimationManager but gave up. That's because it requires NS_IMPL_CYCLE_COLLECTION macro (and two more macrso), I did not come up with an easy way to use the macros for CommonAnimationManager.
I hope someone tries it in other bug.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

11 months ago
I did use StopAnimationsForElement for the new member function here.  I initially use StopForElement() but it's little bit vague, so I did insert 'Animations' as a common word for CSS animations and transitions.
Brian, what do you think about the name?
Flags: needinfo?(bbirtles)
Seems fine to me.
Flags: needinfo?(bbirtles)

Comment 4

11 months ago
mozreview-review
Comment on attachment 8843819 [details]
Bug 1344603 - Make Stop{Animations|Transitions}ForElement as a member function of CommonAnimationManager.

https://reviewboard.mozilla.org/r/117422/#review119046

LGTM
Attachment #8843819 - Flags: review?(boris.chiou) → review+

Comment 6

11 months ago
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s a5919d62c823 -d 26cf91f36f5e: rebasing 379572:a5919d62c823 "Bug 1344603 - Make Stop{Animations|Transitions}ForElement as a member function of CommonAnimationManager. r=boris" (tip)
merging layout/base/RestyleManager.cpp
merging layout/style/nsAnimationManager.cpp
merging layout/style/nsAnimationManager.h
warning: conflicts while merging layout/style/nsAnimationManager.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
(Assignee)

Comment 7

11 months ago
Thank you autoland! I am surprised that you had the ability to notify us when you could not merge commits.
Comment hidden (mozreview-request)

Comment 9

11 months ago
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/911024a9cf3c
Make Stop{Animations|Transitions}ForElement as a member function of CommonAnimationManager. r=boris

Comment 10

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/911024a9cf3c
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.