Closed Bug 1344604 Opened 5 years ago Closed 5 years ago

[webvtt] fix webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/tags.html

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bechen, Assigned: bechen)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
I'm going to fix this because it is a crash case.
The testcase content contains html url encoding:
https://www.w3schools.com/tags/ref_urlencode.asp
Comment on attachment 8847979 [details]
Bug 1344604 - Return null if there is an incomplete tag in nextToken().

https://reviewboard.mozilla.org/r/120938/#review122912
Attachment #8847979 - Flags: review?(alwu) → review+
Comment on attachment 8847980 [details]
Bug 1344604 - part2: Return empty DocumentFragment if the ConvertCueToDOMTree() return null.

https://reviewboard.mozilla.org/r/120940/#review122914

After offline discussion, please open another bug to throw the error when there is no valid DocumentFragment, instead of create an new DocumentFragment.
Attachment #8847980 - Flags: review?(alwu) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/b6252f00b471
Return null if there is an incomplete tag in nextToken(). r=alwu
https://hg.mozilla.org/integration/autoland/rev/c284d23cc142
part2: Return empty DocumentFragment if the ConvertCueToDOMTree() return null. r=alwu
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/b6252f00b471
https://hg.mozilla.org/mozilla-central/rev/c284d23cc142
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.