1344604 - [webvtt] fix webvtt-file-format-parsing/webvtt-cue-text-parsing-rules/tests/tags.html

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Comment 1

[Benjamin Chen [:bechen]]

I'm going to fix this because it is a crash case.

Comment 2

[Benjamin Chen [:bechen]]

The testcase content contains html url encoding:
https://www.w3schools.com/tags/ref_urlencode.asp

Comment 3

[Benjamin Chen [:bechen]]

Attachment: Bug 1344604 - Return null if there is an incomplete tag in nextToken().

Review commit: https://reviewboard.mozilla.org/r/120938/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120938/

Comment 4

[Benjamin Chen [:bechen]]

Attachment: Bug 1344604 - part2: Return empty DocumentFragment if the ConvertCueToDOMTree() return null.

It is a regression of bug1307710, if something wrong during the ConvertCueToDOMTree() in vtt.jsm, we will get null ptr.

Review commit: https://reviewboard.mozilla.org/r/120940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120940/

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8847979 [details]
Bug 1344604 - Return null if there is an incomplete tag in nextToken().

https://reviewboard.mozilla.org/r/120938/#review122912

Comment 6

[Alastor Wu [:alwu]]

Comment on attachment 8847980 [details]
Bug 1344604 - part2: Return empty DocumentFragment if the ConvertCueToDOMTree() return null.

https://reviewboard.mozilla.org/r/120940/#review122914

After offline discussion, please open another bug to throw the error when there is no valid DocumentFragment, instead of create an new DocumentFragment.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b6252f00b471
Return null if there is an incomplete tag in nextToken(). r=alwu
https://hg.mozilla.org/integration/autoland/rev/c284d23cc142
part2: Return empty DocumentFragment if the ConvertCueToDOMTree() return null. r=alwu

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b6252f00b471
https://hg.mozilla.org/mozilla-central/rev/c284d23cc142