1344616 - Support testing content scripts in xpcshell

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1344616: Support running content script tests in xpcshell.

Review commit: https://reviewboard.mozilla.org/r/117440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117440/

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1344616: Migrate content script mochitests to xpcshell.

Review commit: https://reviewboard.mozilla.org/r/117442/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117442/

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8843832 [details]
Bug 1344616: Migrate content script mochitests to xpcshell.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/117442/diff/1-2/

Comment 4

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8843831 [details]
Bug 1344616: Support running content script tests in xpcshell.

https://reviewboard.mozilla.org/r/117440/#review119306

::: testing/mochitest/BrowserTestUtils/ContentTask.jsm:17
(Diff revision 1)
>  
>  const { classes: Cc, interfaces: Ci, utils: Cu } = Components;
>  Cu.import("resource://gre/modules/Promise.jsm");
>  Cu.import("resource://gre/modules/Services.jsm");
>  
> -const FRAME_SCRIPT = "chrome://mochikit/content/tests/BrowserTestUtils/content-task.js";
> +const FRAME_SCRIPT = "resource://testing-common/content-task.js";

Lets keep the BrowserTestUtils changes in the same patch together.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8843832 [details]
Bug 1344616: Migrate content script mochitests to xpcshell.

https://reviewboard.mozilla.org/r/117442/#review119360

::: testing/mochitest/BrowserTestUtils/moz.build:9
(Diff revision 2)
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
>  TESTING_JS_MODULES += [
>      'BrowserTestUtils.jsm',
> +    'content/content-task.js',

dito here, move to the other patch

Comment 6

[Kris Maglione [:kmag]]

Comment on attachment 8843832 [details]
Bug 1344616: Migrate content script mochitests to xpcshell.

https://reviewboard.mozilla.org/r/117442/#review119360

> dito here, move to the other patch

Good catch

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b476abd6506156db7bfe9589cb0de7390969b008
Bug 1344616: Support running content script tests in xpcshell. r=mixedpuppy

https://hg.mozilla.org/integration/mozilla-inbound/rev/295f8f82ced346ca72e836ac9bbc33d21c8e92fd
Bug 1344616: Migrate content script mochitests to xpcshell. r=mixedpuppy

Comment 8

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0aac487103cebe31b430b44d21b89720fc3989ef
Bug 1344616: Follow-up: Fix devtools test failure. r=me

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b476abd65061
https://hg.mozilla.org/mozilla-central/rev/295f8f82ced3
https://hg.mozilla.org/mozilla-central/rev/0aac487103ce