Closed Bug 1344684 Opened 3 years ago Closed 3 years ago

Loading the same image document twice causes a hang in get()

Categories

(Testing :: Marionette, enhancement)

Version 3
enhancement
Not set

Tracking

(firefox52 fixed, firefox-esr52 fixed, firefox53 fixed, firefox54 fixed, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox52 --- fixed
firefox-esr52 --- fixed
firefox53 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Whiteboard: [spec][17/03][fixed by bug 1330348])

The following testcase is failing because get() never returns:

def test_load_same_image_document_twice(self):
    self.marionette.navigate(self.fixtures.where_is("black.png"))
    self.assertIn("black.png", self.marionette.title)
    self.marionette.navigate(self.fixtures.where_is("black.png"))
    self.assertIn("black.png", self.marionette.title)

A fix for bug 1333458 should cover this situation.
We do have a test for navigating _between_ ImageDocument’s:

>     def test_image_document_to_image_document(self):
>         self.marionette.navigate(self.fixtures.where_is("test.html"))
> 
>         self.marionette.navigate(self.fixtures.where_is("white.png"))
>         self.assertIn("white.png", self.marionette.title)
>         self.marionette.navigate(self.fixtures.where_is("black.png"))
>         self.assertIn("black.png", self.marionette.title)

A fix for that was added in https://bugzilla.mozilla.org/show_bug.cgi?id=1322772, which could give useful clues.
Please see the topic of this bug. It is the SAME image document. In your example we have two different images.
Yes, that’s what I said (-:
The problem here is actually that we miss to remove a former progress listener in case of get commands for image documents. I noticed that while working on bug 1330348, so it will be a side-along fix there.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Depends on: 1330348
No longer depends on: webdriver-navigate
This is fixed now given that bug 1330348 landed on mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed by bug 1330348]
Target Milestone: --- → mozilla55
Whiteboard: [fixed by bug 1330348] → [spec][17/03][fixed by bug 1330348]
You need to log in before you can comment on or make changes to this bug.