13447 - [DOGFOOD] [PP] Linux: Backspace and Delete insert spaces

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[cpratt]

Build ID: 1999090908
Platform: RH Linux 6 (only)

To reproduce:
- Launch apprunner
- Click to the right of the URL in the Location: control
- Press Backspace a few times

Result: Spaces are inserted and the caret moves to the right

- Now, click somewhere in the middle of the URL
- Press the Delete key a few times

Result: Characters to the right of the caret are replaced by white space

Expected result: Backspace should move the caret to the left while deleting
characters; Delete should delete the character to the right of the caret while
moving the rest of the text on the line to the left.

Comment 1

[Peter Trudelle]

Reproduced, but only in Ender text widget. changing component to
editor, reassigning to buster

QA: Please take note that text neither text edit widgets nor HTML forms controls
are XPToolkit widgets!

Comment 2

[cpratt]

I hadn't realized that was an Editor problem. All I know is this: if you change
the Debug prefs to use GFX, everything breaks in the browser (the Location:
control etc.).

Comment 3

[buster]

akkana, can you see what's going on here in linux?  I don't see it on windows
at all.
I can't tell if this is a display problem, or a content manipulation problem, or
a keyboard event handling problem?  Are we getting the right commands
(backspace, delete)?  If so, are we manipulating the content correctly (that
should be 100% XP)?  If so, is it just a painting/update problem?
Once you can categorize the problem, please assign to the appropriate person.
Marked dogfood since this certainly would keep people from using the app.

Comment 4

[Akkana Peck]

No, we're never getting the event.  This is because of the XIM code, which
Pavlov just changed.  Reassigning to Pavlov, but meanwhile I'll look into what
we need to change to back this out.  Unfortunately, commenting out the -DUSE_XIM
in the widget/src/gtk Makefile.in causes worse problems (the apprunner window
doesn't even come up).

Comment 5

[cpratt]

Changing QA Contact (sorry, phillip!).

Comment 6

[Akkana Peck]

Changing the USE_XIM on line 704 of nsGtkEventHandler.cpp to USE_XIM_NOT fixes
this problem (but, of course, disables whatever it is that XIM is supposed to be
doing with those keys).

Comment 7

[Akkana Peck]

I've checked in the workaround.

Comment 8

[Chris McAfee]

*** Bug 13467 has been marked as a duplicate of this bug. ***

Comment 9

[Chris McAfee]

This is broken for me tonight.  P2.

Comment 10

[Chris McAfee]

URL bar, text fields, text areas.  This is really broken.
P1.

Comment 11

[Chris McAfee]

This is working for me, marking so.
QA, this might not show up until Tuesday's build.

Comment 12

[cpratt]

Still broken in the 1999092013 build on Linux. btw, I would have marked this
FIXED and not worksforme; please bear in mind that a QA person's review often
contains information about how many of their bugs were judged to be not a bug,
ie worksforme. Thanks!

Comment 13

[Akkana Peck]

I agree, this bug has come back, probably as a result of Steve's change to the
editor event listeners to work around a bug in the Windows event handler.  Turns
out the gtk key handler is sending both keycode and charcode for these events.
I'm working on a fix.

Comment 14

[Akkana Peck]

Checked in a fix for the regression: the gtk event handler now sends key code or
char code, but never both, and backspace and delete events are being handled
properly now.

Comment 15

[rubydoo123]

assigning Pratt as QA contact

Comment 16

[cpratt]

Verified fixed in the 1999092708 build, Linux.