Closed Bug 1344752 Opened 3 years ago Closed 3 years ago

Crash in mozilla::widget::TextEventDispatcher::GetState

Categories

(Core :: Widget: Android, defect, critical)

Unspecified
Android
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: marcia, Assigned: jchen)

References

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-bec2c3ac-cbd5-41c8-b7c7-e21ac2170304.
=============================================================

Seen while looking at nightly crash stats. Crashes started using 20170303110215 build.

Possible regression range: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e91de6fb2b3dce9c932428265b0fdb630ea470d7&tochange=9732cd019a8b94c49a275661320c1b742635a3d6

Bug 1137567 is in the range and touched code in that area. ni on jchen.
Flags: needinfo?(nchen)
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Flags: needinfo?(nchen)
Device: Huawei MediaPad M2 - Android 5.1.1;
Build: Nightly 54.0a1 (2017-03-06).

I was able to reproduce this crash following the steps:
1. Open Fennec;
2. Go to Settings -> Sign in;
3. Create a new account. After I tapped the password and complete the age field, Fennec crashed.
Inside OnImeReplaceText, an action can cause the editor to blur and
mDispatcher to be reset. We should guard against that and abandon
subsequent actions.
Attachment #8844675 - Flags: review?(esawin)
Attachment #8844675 - Flags: review?(esawin) → review+
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72479abe0124
Guard against blurring when replacing text; r=esawin
https://hg.mozilla.org/mozilla-central/rev/72479abe0124
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Please request Aurora approval on this when you get a chance.
Flags: needinfo?(nchen)
Comment on attachment 8844675 [details] [diff] [review]
Guard against blurring when replacing text (v1)

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1137567
[User impact if declined]: Crash when inputting text in some cases
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Patch only covers cases where we used to crash.
[String changes made/needed]: None
Flags: needinfo?(nchen)
Attachment #8844675 - Flags: approval-mozilla-aurora?
Comment on attachment 8844675 [details] [diff] [review]
Guard against blurring when replacing text (v1)

Fix a crash. Aurora54+.
Attachment #8844675 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I can confirm that this is fixed on latest Nightly following the steps from comment 1. Fennec doesn't crash when a new account is made.
You need to log in before you can comment on or make changes to this bug.