1344812 - Fix clang 5.0 warnings for ClearKeySessionManager.cpp: [-Wunused-lambda-capture] lambda capture 'sessionId' is not used

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, enhancement, P2)

Description

[Daniel Holbert [:dholbert]]

clang trunk has added a new build warning "-Wunused-lambda-capture" for variables captured by lambda functions & then unused.

Filing this bug for 3 instances in GMP's C++ file ClearKeySessionManager.cpp
{
media/gmp-clearkey/0.1/ClearKeySessionManager.cpp:235:37 [-Wunused-lambda-capture] lambda capture 'sessionId' is not used
media/gmp-clearkey/0.1/ClearKeySessionManager.cpp:589:49 [-Wunused-lambda-capture] lambda capture 'sessionId' is not used
media/gmp-clearkey/0.1/ClearKeySessionManager.cpp:597:48 [-Wunused-lambda-capture] lambda capture 'sessionId' is not used
}

Historical note: it looks like these variables were already unused in the commit that added these lambda functions, back in bug 1318965.[1][2][3]  (Perhaps they were used in an initial version of that patch, but ended up unused in the final version.)  --> Adding dependency on that bug.

In any case, clearly we don't need to capture them now.

[1] https://hg.mozilla.org/integration/mozilla-inbound/rev/fe0662dd0b839b00710eae1a7a4452625027a03a#l14.280
[2] https://hg.mozilla.org/integration/mozilla-inbound/rev/fe0662dd0b839b00710eae1a7a4452625027a03a#l14.678
[3] https://hg.mozilla.org/integration/mozilla-inbound/rev/fe0662dd0b839b00710eae1a7a4452625027a03a#l14.686

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1344812: Remove variable "sessionId" from lambda-captures where it's not used, in ClearKeySessionManager.cpp.

Review commit: https://reviewboard.mozilla.org/r/117626/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117626/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8844095 [details]
Bug 1344812: Remove variable "sessionId" from lambda-captures where it's not used, in ClearKeySessionManager.cpp.

https://reviewboard.mozilla.org/r/117626/#review119326

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b83517442e40
Remove variable "sessionId" from lambda-captures where it's not used, in ClearKeySessionManager.cpp. r=cpearce

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b83517442e40