1344815 - Show sidebar key combination

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P3)

Description

[Andy McKay]

I've specified a key combination in my manifest.json to open my extension as per bug 1338727. The other sidebar choices show a combination as per screenshot. Not sure how easy it is, but it would be awesome if we could show that keyboard combination in the menu.

Comment 2

[Andy McKay]

Mark, in your travels as commands API expert, would you be able to knock this one out please?

Comment 3

[Mark Striemer [:mstriemer]]

There are two places that we should expose the shortcut:

  1. In the sidebar switcher dropdown
  2. In the menu View > Sidebar

Comment 4

[Ryan Feeley [:rfeeley]]

Attachment: hereandhere.png

Here and here.

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1344815 - Show sidebar shortcut in menus

Review commit: https://reviewboard.mozilla.org/r/217046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/217046/

Comment 6

[Mark Striemer [:mstriemer]]

Comment on attachment 8947327 [details]
Bug 1344815 - Show sidebar shortcut in menus

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217046/diff/1-2/

Comment 7

[Mark Striemer [:mstriemer]]

Comment on attachment 8947327 [details]
Bug 1344815 - Show sidebar shortcut in menus

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/217046/diff/2-3/

Comment 8

[Mark Striemer [:mstriemer]]

Attachment: sidebar-shortcut.mov.gif

Comment 9

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8947327 [details]
Bug 1344815 - Show sidebar shortcut in menus

https://reviewboard.mozilla.org/r/217046/#review222998

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2875a349020
Show sidebar shortcut in menus r=mixedpuppy

Comment 11

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/d2875a349020

Comment 12

[marius.santa]

Is manual testing required on this bug? If Yes, please provide some STR and the proper webextension(if required), if No set the “qe-verify-“ flag.

Comment 13

[Mark Striemer [:mstriemer]]

This can be verified along with bug 1421811 when it lands since it has some code to handle the shortcut changing in the sidebar.

If you'd like to test this right now you can install the test extension from bug 1421811. There is a bug in this where the shortcut isn't shown right after install, but it shows in new windows and subsequent restarts of Firefox (that is fixed in bug 1421811).

STR
1. Install test extension.
2. Open sidebar menu switcher.
3. Verify shortcut is shown.
4. Go to View > Sidebar.
5. Verify that the shortcut is shown.

Comment 14

[marius.santa]

Attachment: shortcut shown.gif

I was able to reproduce the issue on Windows 10 64Bit Firefox 59.0a1 (20180109234707).
Tested and verified on Windows 10 64Bit and Mac OS  X 10.13.2 in Firefox  	60.0a1 (20180219100221).