1344816 - Fix clang 5.0 warnings for U2F.cpp: [-Wunused-lambda-capture] lambda capture 'this' is not used

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement)

Description

[Daniel Holbert [:dholbert]]

clang trunk has added a new build warning "-Wunused-lambda-capture" for
variables captured by lambda functions & then unused.

Filing this bug for 4 instances of this in U2F.cpp:
{
dom/u2f/U2F.cpp:717:19 [-Wunused-lambda-capture] lambda capture 'this' is not used
dom/u2f/U2F.cpp:723:19 [-Wunused-lambda-capture] lambda capture 'this' is not used
dom/u2f/U2F.cpp:903:19 [-Wunused-lambda-capture] lambda capture 'this' is not used
dom/u2f/U2F.cpp:909:19 [-Wunused-lambda-capture] lambda capture 'this' is not used
}

Presumably we're just capturing "this" out of habit, so that we *could* use member-vars & member-functions from these lambdas.  However, we don't use that member stuff, so there's no benefit to capturing 'this'.  So, might as well drop it & end up with fewer build warnings.

Comment 1

[Daniel Holbert [:dholbert]]

I think all of these lambdas come from bug 1297552 - adding dependency on that bug.

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: Bug 1344816: Remove unused 'this' variable lambda-captures from U2F.cpp.

Review commit: https://reviewboard.mozilla.org/r/117634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117634/

Comment 3

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8844100 [details]
Bug 1344816: Remove unused 'this' variable lambda-captures from U2F.cpp.

https://reviewboard.mozilla.org/r/117634/#review119328

LGTM, it was indeed left in there after an in-bug refactor. Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e696aeb1bbf
Remove unused 'this' variable lambda-captures from U2F.cpp. r=jcj

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6e696aeb1bbf