--disable-sandbox broken: fatal error: sandboxPermissions.h: No such file or directory

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Unspecified
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 wontfix, firefox55 fixed)

Details

(Whiteboard: [tor])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
I believe https://bugzilla.mozilla.org/show_bug.cgi?id=1284897 broke --disable-sandbox:

> firefox/dom/ipc/ContentChild.cpp:63:0:
> dist/include/mozilla/plugins/PluginModuleParent.h:27:32: fatal error: sandboxPermissions.h: No such file or directory
> compilation terminated.
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Attachment #8844120 - Flags: review?(davidp99)
(Assignee)

Updated

2 years ago
Assignee: nobody → tom
Blocks: 1330608

Comment 2

2 years ago
mozreview-review
Comment on attachment 8844120 [details]
Bug 1344845 Fix --disable-sandbox by ifdef-ing an include

https://reviewboard.mozilla.org/r/117660/#review119350

Good catch, thanks.
Attachment #8844120 - Flags: review?(davidp99) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 3

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9399e0ccde82
Fix --disable-sandbox by ifdef-ing an include. r=handyman
Keywords: checkin-needed

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9399e0ccde82
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Bug 1284897 is in 54, do we want to uplift this to beta as well?
status-firefox54: affected → fix-optional
Flags: needinfo?(tom)
(Assignee)

Comment 6

a year ago
(In reply to Julien Cristau [:jcristau] from comment #5)
> Bug 1284897 is in 54, do we want to uplift this to beta as well?

I don't need it uplifted, as Tor will not build 54. If you or someone else want it uplifted for completeness reasons, then sure.
Flags: needinfo?(tom)
status-firefox54: fix-optional → wontfix
OS: Unspecified → Windows
You need to log in before you can comment on or make changes to this bug.