|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
I believe https://bugzilla.mozilla.org/show_bug.cgi?id=1284897 broke --disable-sandbox: > firefox/dom/ipc/ContentChild.cpp:63:0: > dist/include/mozilla/plugins/PluginModuleParent.h:27:32: fatal error: sandboxPermissions.h: No such file or directory > compilation terminated.
Comment on attachment 8844120 [details] Bug 1344845 Fix --disable-sandbox by ifdef-ing an include https://reviewboard.mozilla.org/r/117660/#review119350 Good catch, thanks.
Attachment #8844120 - Flags: review?(davidp99) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/9399e0ccde82 Fix --disable-sandbox by ifdef-ing an include. r=handyman
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Bug 1284897 is in 54, do we want to uplift this to beta as well?
status-firefox54: affected → fix-optional
(In reply to Julien Cristau [:jcristau] from comment #5) > Bug 1284897 is in 54, do we want to uplift this to beta as well? I don't need it uplifted, as Tor will not build 54. If you or someone else want it uplifted for completeness reasons, then sure.
You need to log in before you can comment on or make changes to this bug.