Enable flake8 rule F401: "XXX imported but unused"

RESOLVED FIXED in Firefox 55

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Dexter, Assigned: fionn_mac, Mentored)

Tracking

Trunk
mozilla55
Points:
1
Dependency tree / graph

Firefox Tracking Flags

(firefox54 wontfix, firefox55 fixed)

Details

(Whiteboard: [measurement:client][lang=python])

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
+++ This bug was initially created as a clone of Bug #1344854 +++

In bug 1332651 we landed flake8 initial support to lint Python files in the Telemetry directory, by disabling all the detected problems.

This bug is about enabling the F401, "XXX imported but unused":

1) Remove the F401 rule from the .flake8 file in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry

2) Run "./mach lint -l flake8 toolkit/components/telemetry".

3) Fix the reported problems
(Reporter)

Updated

2 years ago
No longer depends on: 1344854
(Reporter)

Updated

2 years ago
Blocks: 1344858
(Reporter)

Updated

2 years ago
No longer blocks: 1344858
(Assignee)

Comment 1

2 years ago
Hello!

I'd like to work on this bug. I'll start work ASAP!
(Reporter)

Updated

2 years ago
Assignee: nobody → vedant.sareen
(Assignee)

Comment 2

2 years ago
Attachment #8845531 - Flags: review?(alessio.placitelli)
(Reporter)

Updated

2 years ago
Attachment #8845531 - Flags: review?(alessio.placitelli) → review+

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/188f56bfe47d
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.