Closed Bug 1344897 Opened 8 years ago Closed 4 years ago

Crash in nsldapi_find_in_cb_pollfds and nsAbQueryLDAPMessageListener::OnLDAPMessageSearchResult

Categories

(MailNews Core :: LDAP Integration, defect)

x86
Windows
defect
Not set
critical

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: wsmwk, Unassigned)

References

Details

(Keywords: crash)

Crash Data

All crash IDs cited in this comment are the same user. If these two crash signatures have the same cause, this is a top 40 crash. #55 crash for 45.7.1 @ nsldapi_find_in_cb_pollfds bp-0f83746a-7e76-411d-bd0c-c953a2170228 0 ldap60.dll nsldapi_find_in_cb_pollfds c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/os-ip.c:1524 1 ldap60.dll nsldapi_iostatus_is_read_ready c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/os-ip.c:1088 2 ldap60.dll wait4msg c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/result.c:474 3 ldap60.dll nsldapi_result_nolock c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/result.c:145 4 ldap60.dll ldap_result c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/result.c:111 5 mozglue.dll arena_dalloc_small memory/mozjemalloc/jemalloc.c:4608 this user also crashes... #146 crash nsAbQueryLDAPMessageListener::OnLDAPMessageSearchResult bp-e941afae-f832-47c1-9458-9fa072170228. 0 xul.dll nsAbQueryLDAPMessageListener::OnLDAPMessageSearchResult(nsILDAPMessage*) c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/mailnews/addrbook/src/nsAbLDAPDirectoryQuery.cpp:286 1 xul.dll nsAbQueryLDAPMessageListener::OnLDAPMessage(nsILDAPMessage*) c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/mailnews/addrbook/src/nsAbLDAPDirectoryQuery.cpp:175 2 xul.dll nsOnLDAPMessageRunnable::Run() c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/xpcom/src/nsLDAPConnection.cpp:413 3 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp:972 a different example of nsldapi_find_in_cb_pollfds bp-ed81d23a-60c5-42fd-8850-b27752170217 0 ldap60.dll nsldapi_find_in_cb_pollfds c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/os-ip.c:1524 1 ldap60.dll nsldapi_iostatus_is_read_ready c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/os-ip.c:1088 2 ldap60.dll wait4msg c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/result.c:474 3 ldap60.dll nsldapi_result_nolock c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/result.c:145 4 ldap60.dll ldap_result c:/builds/moz2_slave/tb-rel-c-esr45-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/result.c:111 5 mozglue.dll arena_dalloc memory/mozjemalloc/jemalloc.c:4736 6 nss3.dll _PR_MD_UNLOCK nsprpub/pr/src/md/windows/w95cv.c:365
Hi Wayne, My TB 59.0b2 (32-bit) crash/closed unexpectedly after going to Addressbook and starting to type few letters in the quick search field to find a contact. In addition of local addressbook I am also connected to few LDAP addressbooks. This happens everytime I retry. Below are the bug reports generated but NOT send automatically (no prompt windows to allow me to do so) but strangely the TB version in them is set to 54.0b3 while crash occurred with version 59.0b2 currently in use... bp-ee323941-a6d5-4315-a7d5-c1b460180307 bp-708ce597-8032-4daa-ba6c-a899d0180307 I send them afterwards by going into Help > Troubleshooting and clicking on each of them. I notice they both relate to this bug that is why I report my issue here for information if that can help in any way to fix the issue. Regards, Richard
For the record it started to happen with some of the previous version of TB I used but would not be able to tell which one. I first thought it was crashing without generating a bug report as the bug report prompt window was not appearing to allow me to send and report back to bugzilla about it. But as it reproduced today, I found out bug reports were generated but not sent automatically... which I did by clicking on them...
Blocks: 1443855
bp-0a113a0e-dcc9-4e5d-a137-e87810181024 ldap autocomplete 0 ldap60.dll nsldapi_find_in_cb_pollfds C:/builds/moz2_slave/tb-rel-c-esr52-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/os-ip.c:1524 1 ldap60.dll nsldapi_iostatus_is_read_ready C:/builds/moz2_slave/tb-rel-c-esr52-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/os-ip.c:1087 2 ldap60.dll wait4msg C:/builds/moz2_slave/tb-rel-c-esr52-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/result.c:473 3 ldap60.dll nsldapi_result_nolock C:/builds/moz2_slave/tb-rel-c-esr52-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/result.c:144 4 ldap60.dll ldap_result C:/builds/moz2_slave/tb-rel-c-esr52-w32_bld-0000000/build/ldap/c-sdk/libraries/libldap/result.c:111 5 xul.dll nsLDAPConnectionRunnable::Run() C:/builds/moz2_slave/tb-rel-c-esr52-w32_bld-0000000/build/ldap/xpcom/src/nsLDAPConnection.cpp:633 6 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp:1216 bp-752e4e8d-e81b-411e-9513-3619b0181003 richard 0 xul.dll nsAbQueryLDAPMessageListener::OnLDAPMessageSearchResult(nsILDAPMessage*) comm/mailnews/addrbook/src/nsAbLDAPDirectoryQuery.cpp:285 1 xul.dll nsAbQueryLDAPMessageListener::OnLDAPMessage(nsILDAPMessage*) comm/mailnews/addrbook/src/nsAbLDAPDirectoryQuery.cpp:166 2 xul.dll nsOnLDAPMessageRunnable::Run() comm/ldap/xpcom/src/nsLDAPConnection.cpp:414 3 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp:1040 Ø 4 ntdll.dll ntdll.dll@0x6c6cc red herring?
Richard's bp-e70a05bc-dd42-44b5-8793-b09b50181101 from bug 1333031 @ nsAbQueryLDAPMessageListener::OnLDAPMessage 0 xul.dll nsAbQueryLDAPMessageListener::OnLDAPMessage(nsILDAPMessage*) comm/mailnews/addrbook/src/nsAbLDAPDirectoryQuery.cpp:174 1 xul.dll nsOnLDAPMessageRunnable::Run() comm/ldap/xpcom/src/nsLDAPConnection.cpp:412 2 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp:1245 3 xul.dll NS_ProcessNextEvent(nsIThread*, bool) xpcom/threads/nsThreadUtils.cpp:530 4 xul.dll nsXULWindow::ShowModal() xpfe/appshell/nsXULWindow.cpp:411 5 xul.dll nsContentTreeOwner::ShowAsModal() xpfe/appshell/nsContentTreeOwner.cpp:489 6 xul.dll nsWindowWatcher::OpenWindowInternal(mozIDOMWindowProxy*, char const*, char const*, char const*, bool, bool, bool, nsIArray*, bool, bool, nsDocShellLoadInfo*, mozIDOMWindowProxy**) toolkit/components/windowwatcher/nsWindowWatcher.cpp:1264
Crash Signature: [@ nsAbQueryLDAPMessageListener::OnLDAPMessageSearchResult] [@ nsldapi_find_in_cb_pollfds ] → [@ nsAbQueryLDAPMessageListener::OnLDAPMessageSearchResult] [@ nsldapi_find_in_cb_pollfds ] [@ nsAbQueryLDAPMessageListener::OnLDAPMessage ]

Do these make sense as a group? Or are they distinct and different issues?

all 60.8.0

nsldapi_find_in_cb_pollfds bp-431cc793-18f9-496b-ac44-af5630190716

Frame Module Signature Source Trust
0 ldap60.dll nsldapi_find_in_cb_pollfds comm/ldap/c-sdk/libraries/libldap/os-ip.c:1524 context
1 ldap60.dll nsldapi_iostatus_is_read_ready comm/ldap/c-sdk/libraries/libldap/os-ip.c:1087 cfi
2 ldap60.dll wait4msg comm/ldap/c-sdk/libraries/libldap/result.c:473 cfi
3 ldap60.dll nsldapi_result_nolock comm/ldap/c-sdk/libraries/libldap/result.c:144 cfi
4 ldap60.dll ldap_result comm/ldap/c-sdk/libraries/libldap/result.c:111 cfi
5 xul.dll nsLDAPConnectionRunnable::Run() comm/ldap/xpcom/src/nsLDAPConnection.cpp:634 cfi
6 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp:975 cfi
7 ntdll.dll RtlpWakeSRWLock scan
8 xul.dll mozilla::Variant<JSAtom*, char16_t const*, mozilla::UniquePtr<char16_t [0], JS::FreePolicy> >::extract<0>() mfbt/Variant.h:680 scan
9 xul.dll mozilla::Variant<int const, char const*, void ()(nsITimer, bool, void*, char*, unsigned int)>::operator=(mozilla::Variant<int const, char const*, void ()(nsITimer, bool, void*, char*, unsigned int)>&&) mfbt/Variant.h:575 cfi

nsAbQueryLDAPMessageListener::OnLDAPMessage bp-UUID 3234967b-9444-4aa8-89cf-ef3270190716
0 xul.dll nsAbQueryLDAPMessageListener::OnLDAPMessage(nsILDAPMessage*) comm/mailnews/addrbook/src/nsAbLDAPDirectoryQuery.cpp:186 context
1 xul.dll nsOnLDAPMessageRunnable::Run() comm/ldap/xpcom/src/nsLDAPConnection.cpp:414 cfi
2 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp:975 cfi
3 ntdll.dll RtlAcquireSRWLockExclusive scan

nsAbQueryLDAPMessageListener::OnLDAPMessageSearchResult bp-731566db-610b-4ac3-9d26-8c9430190716
0 xul.dll nsAbQueryLDAPMessageListener::OnLDAPMessageSearchResult(nsILDAPMessage*) comm/mailnews/addrbook/src/nsAbLDAPDirectoryQuery.cpp:285 context
1 xul.dll nsAbQueryLDAPMessageListener::OnLDAPMessage(nsILDAPMessage*) comm/mailnews/addrbook/src/nsAbLDAPDirectoryQuery.cpp:174 cfi
2 xul.dll nsOnLDAPMessageRunnable::Run() comm/ldap/xpcom/src/nsLDAPConnection.cpp:414 cfi
3 xul.dll nsThread::ProcessNextEvent(bool, bool*) xpcom/threads/nsThread.cpp:975 cfi
4 ntdll.dll RtlpWakeSRWLock scan
5 xul.dll mozilla::Variant<JSAtom*, char16_t const*, mozilla::UniquePtr<char16_t [0], JS::FreePolicy> >::extract<0>() mfbt/Variant.h:680 scan
6 xul.dll std::swap<mozilla::Variant<int const, char const*, void ()(nsITimer, bool, void*, char*, unsigned int)>, void>(mozilla::Variant<int const, char const*, void ()(nsITimer, bool, void*, char*, unsigned int)>&, mozilla::Variant<int const, char const*, void ()(nsITimer, bool, void*, char*, unsigned int)>&) vs2017_15.4.2/VC/include/utility:69 cfi_scan

Flags: needinfo?(m_kato)
OS: Windows 7 → Windows

null check can avoid this crash, but I don't know about root case.

Flags: needinfo?(m_kato)

No topcrash in 68.x, and looks like only nsAbQueryLDAPMessageListener::OnLDAPMessage is left
bp-5a54abde-c00c-424f-bd12-0712a0191001
bp-a4735f8e-5012-45a8-bcba-6b8d00190927

No crashes for 78.5.1 and newer, so fixed by one of these

  • Bug 1662433 - MCD autoconfig disfunctional for Thunderbird 78, affecting enterprise deployment (function processLDAPValues(values) does not return any values in Thunderbird 68.3.1+)
  • Bug 1659947 - Secure LDAP with self signed cerfifcate not working since Update from 68.9.0 to 78.1.1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.