1344921 - In mingw, jumps that cross initializations are errors. Affects WindowsDllBlocklist.cpp

Status: RESOLVED FIXED

(Core :: Security, defect)

Description

[Tom Ritter [:tjr]]

> /tmp/workspace/mingw-w64-build/firefox/mozglue/build/WindowsDllBlocklist.cpp:689:1: error: jump to label 'continue_loading' [-fpermissive]
>  continue_loading:
>  ^
> /tmp/workspace/mingw-w64-build/firefox/mozglue/build/WindowsDllBlocklist.cpp:577:12: note:   from here
>        goto continue_loading;
>             ^
> /tmp/workspace/mingw-w64-build/firefox/mozglue/build/WindowsDllBlocklist.cpp:615:23: note:   crosses initialization of 'const DllBlockInfo* info'
>    const DllBlockInfo* info = &sWindowsDllBlocklist[0];
>                        ^

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1344921 relocate initialization (and declaration) of variable to not allow a jump to bypass it

Review commit: https://reviewboard.mozilla.org/r/123216/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123216/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8850662 [details]
Bug 1344921 relocate initialization (and declaration) of variable to not allow a jump to bypass it

https://reviewboard.mozilla.org/r/123216/#review127166

Comment 3

[Ian Moody [:Kwan] (UTC+1)]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8664b032a330
relocate initialization (and declaration) of variable to not allow a jump to bypass it r=froydnj

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8664b032a330