1344923 - Adding GA Requirements to Global Nav

Status: RESOLVED FIXED

(www.mozilla.org :: Analytics, enhancement)

Description

[pgerman]

Hi Team,

I've put the following requirements doc together:
https://docs.google.com/document/d/1R_AF7YDa3sfz3u0y4W5qRoaWVllKWz00r9H9tIHzVsA/

There are some questions that I have re:download button in the global nav, however the non-download functionality should be complete.

Will connect with Alex and Gareth to review

Thanks,

PG

Comment 1

[pgerman]

There are updated requirements in the link from Comment 2. 

See section 3 about canonical tags at destination sites and section 4 about download link tracking.

Comment 2

[pgerman]

Hi Alex, please see the updates in the doc.

Thanks,

PG

Comment 3

[Alex Gibson [:agibson]]

Looks good, thanks

Comment 4

[Alex Gibson [:agibson]]

Hi Gareth,

The nav prototype is now up on demo for analytics testing:

https://www-demo5.allizom.org/en-US/

As well as implementing the data-attributes Peter requested in the doc above, I also added the following custom events:

window.dataLayer.push({
    'event': 'global-nav',
    'interaction': 'menu-close'
});

window.dataLayer.push({
    'event': 'global-nav',
    'interaction': 'menu-open'
});

window.dataLayer.push({
    'event': 'global-nav',
    'interaction': 'secondary-nav-expand',
    'secondary-nav-heading': <heading-id>
});

window.dataLayer.push({
    'event': 'global-nav',
    'interaction': 'secondary-nav-collapse',
    'secondary-nav-heading': <heading-id>
});

window.dataLayer.push({
    'event': 'global-nav',
    'interaction': 'change-language',
    'languageSelected': <language>,
    'previousLanguage': <previousLanguage>
});

When time allows can you please test and confirm things look ok? Any changes or alterations just let me know.

Thanks!

Comment 5

[pgerman]

Hi Alex,

I see that we decided to implement something different from the doc. Let's sync up so that I have the context on this.

Thanks,

PG

Comment 6

[pgerman]

Hi Alex,
 
I've updated requirements in the doc. Please look at sections 6,7,and 8.

Please remove the datalayer.push functionality for these elements are replace it with the data attributes specified.

Thanks,

PG

Comment 7

[Alex Gibson [:agibson]]

(In reply to pgerman from comment #6)
> Hi Alex,
>  
> I've updated requirements in the doc. Please look at sections 6,7,and 8.
> 
> Please remove the datalayer.push functionality for these elements are
> replace it with the data attributes specified.
> 
> Thanks,
> 
> PG

Peter, I don't quite understand why you want these new items as dynamic data attributes? It would be better performance wise to avoid needing to write these to the DOM each time a user interacts with the nav. Using custom events is going to be quicker / easier to implement also. Perhaps I'm just not understanding what you want here. 

Please ping me later and we can sync up.

Comment 8

[pgerman]

Alex and I have synced up. I'm going to build tag manager configurations based on the current state as the dev track is pressed for time.

We are going to incur technical debt that needs to be revised in an upcoming sprint. At a later date we will need to prioritize updating the deployment in a way that does not jeopardize conducting analysis for this experiment.

Comment 9

[Alex Gibson [:agibson]]

Hi Peter,

Now that the initial PR for the global nav is out the door and live, I've had time to revisit your GA requirements for the dynamic data-attributes outlined in the google doc.

I've created a patch and pushed it to demo5:

https://www-demo5.allizom.org/en-US/

Could you please take a look and verify that things look ok?

I've also added the correct data-attributes for the promo images, which we're rushed in last minute.

Feel free to ping me with and Q's - thanks!

Comment 10

[pgerman]

Hi Alex,

I've looked at these, and they are good on Demo 5. I think it makes sense to push them along with a revision of the nav as there will be a natural break in the data at that point as well.

Comment 11

[Alex Gibson [:agibson]]

(In reply to pgerman from comment #10)
> Hi Alex,
> 
> I've looked at these, and they are good on Demo 5. I think it makes sense to
> push them along with a revision of the nav as there will be a natural break
> in the data at that point as well.

I'd like to get this out next week ideally - I don't think it's worth keeping this branch up to date for a long length of time, as the next time the nav updates it *could* change drastically?

Comment 12

[Alex Gibson [:agibson]]

(In reply to Alex Gibson [:agibson] from comment #11)
> (In reply to pgerman from comment #10)
> > Hi Alex,
> > 
> > I've looked at these, and they are good on Demo 5. I think it makes sense to
> > push them along with a revision of the nav as there will be a natural break
> > in the data at that point as well.
> 
> I'd like to get this out next week ideally - I don't think it's worth
> keeping this branch up to date for a long length of time, as the next time
> the nav updates it *could* change drastically?

The other option is I can remove these changes from the branch in Bug 1353291 and we can revisit the GA change later.

What do you think works best here, Peter? Thanks.

Comment 13

[pgerman]

Remove it from the branch, then we'll roll it out when we make any updates to the nav.

Comment 14

[Alex Gibson [:agibson]]

(In reply to pgerman from comment #13)
> Remove it from the branch, then we'll roll it out when we make any updates
> to the nav.

We are making updates to the nav now as part of this change, see bug 1353587

Comment 15

[Alex Gibson [:agibson]]

Hi Peter,

The good ship bug 1353587 is sailing soon. If you want these changes I suggest we do it now, else I can remove the changes and close this bug as incomplete (we can then update GA next time the nav changes, but I don't know if/when that will be).

Also, do we still need the survey running? If we have enough data can we close it off? Thanks

Comment 16

[Alex Gibson [:agibson]]

Fixed in Bug 1353587