The default bug view has changed. See this FAQ.

Allowing screensharing with no screen selected will temporarily block the camera

VERIFIED FIXED in Firefox 53

Status

()

Firefox
Site Identity and Permission Panels
P1
normal
VERIFIED FIXED
23 days ago
9 days ago

People

(Reporter: johannh, Assigned: Nihanth, Mentored)

Tracking

({regression})

Trunk
Firefox 55
regression
Points:
---

Firefox Tracking Flags

(firefox52 unaffected, firefox53+ fixed, firefox54 verified, firefox55 verified, firefox-esr52 unaffected)

Details

(Whiteboard: [fxprivacy] )

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

23 days ago
str
STR:

- Go to https://people-mozilla.org/~fqueze2/webrtc/
- Click on "Screen"
- Click "Allow" without selecting a screen to share
- Notice that the camera is temporarily blocked

This is because this line http://searchfox.org/mozilla-central/source/browser/modules/webrtcUI.jsm#752 assumes we always share the camera and doesn't account for sharingScreen.

It should probably simply return; when sharingScreen is true since that means the user has not selected a screen. I don't think it's fair to temp block the website here as the user could have made that choice accidentally.
[Tracking Requested - why for this release]: regression from bug 1206232 which landed for 53.
status-firefox53: --- → affected
status-firefox54: --- → affected
tracking-firefox53: --- → ?
Keywords: regressionwindow-wanted
(Reporter)

Comment 2

23 days ago
Nihanth, would you like to take this bug?
Flags: needinfo?(nhnt11)
(Assignee)

Updated

23 days ago
Assignee: nobody → nhnt11
Flags: needinfo?(nhnt11)

Updated

17 days ago
Iteration: --- → 55.1 - Mar 20
Priority: -- → P1
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Reporter)

Comment 5

17 days ago
mozreview-review
Comment on attachment 8846782 [details]
Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.

https://reviewboard.mozilla.org/r/119786/#review121668

Looks great, thanks for spotting the redundant else branch there.
Attachment #8846782 - Flags: review?(jhofmann) → review+
Please land and request uplift to 54 and 53.  Thanks!
Flags: needinfo?(nhnt11)

Comment 7

15 days ago
Pushed by nhnt11@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/45028a73f2c9
Allowing screensharing with no screen selected should not block the camera. r=johannh
(Assignee)

Comment 8

15 days ago
Comment on attachment 8846782 [details]
Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.

Approval Request Comment
[Feature/Bug causing the regression]: Regression from bug 1206232
[User impact if declined]: Confusing behavior, see bug title.
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no, but STR are in comment 0.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: It removes a block of code that sets "block" permission within the callback for the "Allow" button. That code shouldn't be there, and removing it can't cause any harm.
[String changes made/needed]: none
Flags: needinfo?(nhnt11)
Attachment #8846782 - Flags: approval-mozilla-beta?
Attachment #8846782 - Flags: approval-mozilla-aurora?
(Reporter)

Updated

14 days ago
Status: NEW → ASSIGNED
Track 53+ as regression.
tracking-firefox53: ? → +

Comment 10

14 days ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/45028a73f2c9
Status: ASSIGNED → RESOLVED
Last Resolved: 14 days ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I have reproduced this bug with Nightly 55.0a1 (2017-03-07) (64-bit) on Windows 7 , 64 Bit!

This bug's fix is verified with latest Nightly!

Build ID   : 20170317030204
User Agent : Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170315]

Comment 12

13 days ago
Build ID: 20170317030204
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Comment on attachment 8846782 [details]
Bug 1345079 - Allowing screensharing with no screen selected should not block the camera.

Fix a regression issue related to permission and was verified. Aurora54+ & Beta53+.
Attachment #8846782 - Flags: approval-mozilla-beta?
Attachment #8846782 - Flags: approval-mozilla-beta+
Attachment #8846782 - Flags: approval-mozilla-aurora?
Attachment #8846782 - Flags: approval-mozilla-aurora+

Comment 14

10 days ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/660fe0a12cf6
status-firefox54: affected → fixed

Comment 15

10 days ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/347d062eb8e9
status-firefox53: affected → fixed
QA Whiteboard: [good first verify]

Comment 16

9 days ago
Build ID: 20170321004003
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0

Verified as fixed on Firefox Aurora 54.0a2 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
status-firefox54: fixed → verified
Blocks: 1206232
status-firefox52: --- → unaffected
status-firefox-esr52: --- → unaffected
You need to log in before you can comment on or make changes to this bug.