Closed
Bug 1345138
Opened 3 years ago
Closed 3 years ago
Port bug 1310127 [Use MOZ_MUST_USE] and bug 1337893 [changes to nsIDNSService::AsyncResolve] to mailnews.
Categories
(MailNews Core :: Backend, enhancement)
MailNews Core
Backend
Not set
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 55.0
People
(Reporter: jorgk, Assigned: jorgk)
Details
Attachments
(1 file, 1 obsolete file)
|
4.13 KB,
patch
|
Details | Diff | Splinter Review |
nsMsgMdnGenerator.cpp:671:50: error: ignoring return value of function declared with attribute warn_unused_result [-Werror=unused-result]
|
Assignee | |
Comment 1•3 years ago
|
||
Second bustage of the day: nsLDAPConnection.cpp(156): error C2660: 'nsIDNSService::AsyncResolve': function does not take 5 arguments Come comes from bug Bug 1337893: https://hg.mozilla.org/integration/autoland/rev/b8ee0c21d462#l2.56
Summary: Port bug 1310127 Use MOZ_MUST_USE to mailnews → Port bug 1310127 Use MOZ_MUST_USE to mailnews, Port bug Bug 1337893 to mailnews.
|
|
Assignee | |
Comment 2•3 years ago
|
||
Let's see whether this works, sadly on Windows I don't see all the warnings which are promoted to errors. So try here: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d74abfe7f94fc75a7044f09dfe0a8b1f6c658369
Assignee: nobody → jorgk
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•3 years ago
|
||
This compiles now. Model here: https://hg.mozilla.org/mozilla-central/rev/a98c0d18ca5e#l13.12 Sadly I have to wait for https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=1f7251342d0a09b322984694025ba3692b2366b8 to push this.
Attachment #8844506 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•3 years ago
|
||
https://hg.mozilla.org/comm-central/rev/c1860a0bb7cabf5fa917f7ffa4819d3bd45493e3 This should do it, at least Windows will compile with this. Too impatient, didn't wait for the try run.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Summary: Port bug 1310127 Use MOZ_MUST_USE to mailnews, Port bug Bug 1337893 to mailnews. → Port bug 1310127 [Use MOZ_MUST_USE] and bug 1337893 [changes to nsIDNSService::AsyncResolve] to mailnews.
Target Milestone: --- → Thunderbird 55.0
You need to log in
before you can comment on or make changes to this bug.
Description
•