stylo: shorthand serialization doesn't match Gecko

RESOLVED FIXED

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bzbarsky, Assigned: jdm)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 wontfix, firefox56 wontfix, firefox57 fixed)

Details

Some testcases:

 <body style="border-top: 1px solid green; border-color: red;">
   <script>document.writeln(document.body.style.cssText);</script>

 <body style="border-color: red; border-top: 1px solid green">
   <script>document.writeln(document.body.style.cssText);</script>

Plus of course we need to pass layout/style/test/test_shorthand_property_getters.html
And of course maybe it's ok to change behavior here given lack of interop.  But we should do that consciously...
Priority: -- → P3
Blocks: 1362914
Bumping priority given bug 1362914.
Priority: P3 → P2
Summary: stylo: verify that shorthand serialization matches Gecko → stylo: shorthand serialization doesn't match Gecko
Assignee: nobody → kuoe0
Priority: P2 → --
Priority: -- → P2
I have a patch that fixes this particular testcase but breaks some others. I'm going to take a look at how Gecko's implementation compares to the CSS spec.
Assignee: kuoe0 → josh
Josh, what's the status here?
Flags: needinfo?(josh)
Newest try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6da6d7ff309b88f7646c8114f921c36ba8057ef3
Just waiting on review now. I think the changes should be uncontroversial.
Flags: needinfo?(josh)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Too late for 56. Mass won't fix for 56.
You need to log in before you can comment on or make changes to this bug.