1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild)

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, enhancement)

Description

[Florian Quèze [:florian]]

Attachment: xpcshell script

I missed this case when I worked on bug 1334831. It's straight forward to script and lint.

Comment 1

[Florian Quèze [:florian]]

Attachment: Tweak to the eslint rule + script generated patch

No hand editing at all here. Will of course push to try.

Comment 2

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba2169c2382d

Comment 3

[Florian Quèze [:florian]]

Attachment: revert changes that failed on try

I filed bug 1345301 for what looks like an actual bug.

The other failure was because .remove() doesn't return the removed node, and maction-dynamic-embellished-op.html uses removeChild's return value.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8844650 [details] [diff] [review]
Tweak to the eslint rule + script generated patch

Review of attachment 8844650 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me, I reviewed the avoid-removeChild.js changes and package.json closely. All other files I skimmed through.

Comment 5

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1a2b467e5660da4ed8dc7a5ef3077b357aba087f
Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1a2b467e5660