1345436 - "iPhone 6s Plus" should be included devtools's "Responsive Design Mode" featured devices list.

Status: RESOLVED INVALID

(DevTools :: Responsive Design Mode, defect)

Description

[Futa Ogawa]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce:

Open devtools's "Responsive Design Mode".


Actual results:

Featured devices list (default devices list) not included "iPhone 6 Plus", but not included "iPhone 6s Plus".


Expected results:

It should be included "iPhone 6s Plus" only.

Comment 1

[Futa Ogawa]

Attachment: Bug 1345436 - Switch "iPhone 6 Plus" to "iPhone 6s Plus" in devtools's "Responsive Design Mode" featured devices.

Review commit: https://reviewboard.mozilla.org/r/118186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118186/

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Thanks for the report!  The list of devices is actually maintained in a separate repo on GitHub (https://github.com/mozilla/simulated-devices).  The file you've modified here is only used for a test case, so it wouldn't actually update the list for real.

If you have a common device you'd like to see added, I'd suggest filing a PR over on that repo.  As for the featured flags, we're using market data from BrowserStack to drive which devices we mark:

https://www.browserstack.com/test-on-the-right-mobile-devices

We have bug 1318181 to update these, so I'll try to push that forward.

Comment 3

[Futa Ogawa]

Thanks for your response!
I will send pull request on GitHub.

Thanks!