Add new AudioNodes to the Web Audio devtools

RESOLVED FIXED in Firefox 55

Status

enhancement
RESOLVED FIXED
3 years ago
5 months ago

People

(Reporter: padenot, Assigned: padenot)

Tracking

unspecified
Firefox 55

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

No description provided.
Assignee: nobody → padenot
Comment on attachment 8844967 [details]
Bug 1345517 - Add new AudioNodes to the Web Audio devtools.

https://reviewboard.mozilla.org/r/118216/#review120098

Looks good!
Attachment #8844967 - Flags: review?(jordan) → review+
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/autoland/rev/e989c259852d
Add new AudioNodes to the Web Audio devtools. r=jsantell
Backed out

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e989c259852d89c1103133bd787b7ec4154db4ab&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Failure log eslint:
https://treeherder.mozilla.org/logviewer.html#?job_id=82512367&repo=autoland
TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/devtools/shared/specs/webaudio.js:17:1 | Line 17 exceeds the maximum line length of 90. (max-len)
TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/devtools/shared/specs/webaudio.js:19:1 | Line 19 exceeds the maximum line length of 90. (max-len)

Failure log devtools (check the other devtools failures if they other different issues):
https://treeherder.mozilla.org/logviewer.html#?job_id=82519098&repo=autoland

10:18:45     INFO - TEST-START | devtools/client/webaudioeditor/test/browser_audionode-actor-bypass.js
10:18:46     INFO - TEST-INFO | started process screencapture
10:18:46     INFO - TEST-INFO | screencapture: exit 0
10:18:46     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webaudioeditor/test/browser_audionode-actor-bypass.js | head.js import threw an exception - at resource://gre/modules/commonjs/toolkit/loader.js:780 - SyntaxError: JSON.parse: expected ',' or '}' after property value in object at line 119 column 3 of the JSON data
10:18:46     INFO - Entering test bound 
10:18:46     INFO - *************************
10:18:46     INFO - A coding exception was thrown and uncaught in a Task.
10:18:46     INFO - Full message: ReferenceError: can't access lexical declaration `SIMPLE_CONTEXT_URL' before initialization
10:18:46     INFO - Full stack: @chrome://mochitests/content/browser/devtools/client/webaudioeditor/test/browser_audionode-actor-bypass.js:9:7
10:18:46     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:735:9
10:18:46     INFO - Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:655:7
10:18:46     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:791:59
10:18:46     INFO - *************************
10:18:46     INFO - Not taking screenshot here: see the one that was previously logged
10:18:46     INFO - TEST-UNEXPECTED-FAIL | devtools/client/webaudioeditor/test/browser_audionode-actor-bypass.js | Uncaught exception - at chrome://mochitests/content/browser/devtools/client/webaudioeditor/test/browser_audionode-actor-bypass.js:9 - ReferenceError: can't access lexical declaration `SIMPLE_CONTEXT_URL' before initialization
10:18:46     INFO - Stack trace:
10:18:46     INFO -     @chrome://mochitests/content/browser/devtools/client/webaudioeditor/test/browser_audionode-actor-bypass.js:9:7
10:18:46     INFO -     Tester_execTest@chrome://mochikit/content/browser-test.js:735:9
10:18:46     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:655:7
10:18:46     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:791:59
10:18:46     INFO -     Tester_execTest@chrome://mochikit/content/browser-test.js:735:9
10:18:46     INFO -     Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:655:7
10:18:46     INFO -     SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:791:59
10:18:46     INFO - Leaving test bound
Flags: needinfo?(padenot)
Backout by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/ec97bf5faa8c
Backed out changeset e989c259852d for failing eslint and devtools browser_telemetry_toolboxtabs_webaudioeditor.js. r=backout
Pushed by paul@paul.cx:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96c0f5150638
Add new AudioNodes to the Web Audio devtools. r=jsantell
https://hg.mozilla.org/mozilla-central/rev/96c0f5150638
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Flags: needinfo?(padenot)
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.