Fix missing tab details in pageAction.onClicked events on Android

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
WebExtensions: Android
P2
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: rpl, Assigned: rpl)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [pageAction] triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
This is a follow up of Bug 1267402 (which introduced basic support of the pageAction API on Android) and Bug 1260548 (which introduced basic support of the tabs API on Android).

Now that we have added support for the internals needed to generate the tab details from a Firefox for Android tab, we can add the missing tab details from the parameters expected by a pageAction.onClicked listener.
(Assignee)

Updated

4 months ago
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Iteration: --- → 55.1 - Mar 20
Priority: -- → P2
Whiteboard: [pageAction] triaged
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Attachment #8845076 - Flags: review?(kmaglione+bmo)

Comment 2

4 months ago
mozreview-review
Comment on attachment 8845076 [details]
Bug 1345574 - Fix missing tab details in pageAction.onClicked events on Android.

https://reviewboard.mozilla.org/r/118290/#review120162

::: mobile/android/components/extensions/ext-pageAction.js:44
(Diff revision 1)
>          win.BrowserApp.addTab(this.popupUrl, {
>            selected: true,
>            parentId: win.BrowserApp.selectedTab.id,
>          });
>        } else {
> -        this.emit("click");
> +        this.emit("click", win.BrowserApp.selectedTab);

Please use `tabTracker.activeTab` instead. And please assign that to `tab` rather than creating a `win` variable.
Attachment #8845076 - Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

4 months ago
Keywords: checkin-needed

Comment 4

4 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c3f5c270df0e
Fix missing tab details in pageAction.onClicked events on Android. r=kmag
Keywords: checkin-needed

Comment 5

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/c3f5c270df0e
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.