1345574 - Fix missing tab details in pageAction.onClicked events on Android

Status: RESOLVED FIXED

(WebExtensions :: Android, enhancement, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

This is a follow up of Bug 1267402 (which introduced basic support of the pageAction API on Android) and Bug 1260548 (which introduced basic support of the tabs API on Android).

Now that we have added support for the internals needed to generate the tab details from a Firefox for Android tab, we can add the missing tab details from the parameters expected by a pageAction.onClicked listener.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1345574 - Fix missing tab details in pageAction.onClicked events on Android.

Review commit: https://reviewboard.mozilla.org/r/118290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118290/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8845076 [details]
Bug 1345574 - Fix missing tab details in pageAction.onClicked events on Android.

https://reviewboard.mozilla.org/r/118290/#review120162

::: mobile/android/components/extensions/ext-pageAction.js:44
(Diff revision 1)
>          win.BrowserApp.addTab(this.popupUrl, {
>            selected: true,
>            parentId: win.BrowserApp.selectedTab.id,
>          });
>        } else {
> -        this.emit("click");
> +        this.emit("click", win.BrowserApp.selectedTab);

Please use `tabTracker.activeTab` instead. And please assign that to `tab` rather than creating a `win` variable.

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8845076 [details]
Bug 1345574 - Fix missing tab details in pageAction.onClicked events on Android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/118290/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c3f5c270df0e
Fix missing tab details in pageAction.onClicked events on Android. r=kmag

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c3f5c270df0e