Closed Bug 1345574 Opened 3 years ago Closed 3 years ago

Fix missing tab details in pageAction.onClicked events on Android

Categories

(WebExtensions :: Android, enhancement, P2)

enhancement

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Iteration:
55.1 - Mar 20
Tracking Status
firefox55 --- fixed

People

(Reporter: rpl, Assigned: rpl)

Details

(Whiteboard: [pageAction] triaged)

Attachments

(1 file)

This is a follow up of Bug 1267402 (which introduced basic support of the pageAction API on Android) and Bug 1260548 (which introduced basic support of the tabs API on Android).

Now that we have added support for the internals needed to generate the tab details from a Firefox for Android tab, we can add the missing tab details from the parameters expected by a pageAction.onClicked listener.
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Iteration: --- → 55.1 - Mar 20
Priority: -- → P2
Whiteboard: [pageAction] triaged
Attachment #8845076 - Flags: review?(kmaglione+bmo)
Comment on attachment 8845076 [details]
Bug 1345574 - Fix missing tab details in pageAction.onClicked events on Android.

https://reviewboard.mozilla.org/r/118290/#review120162

::: mobile/android/components/extensions/ext-pageAction.js:44
(Diff revision 1)
>          win.BrowserApp.addTab(this.popupUrl, {
>            selected: true,
>            parentId: win.BrowserApp.selectedTab.id,
>          });
>        } else {
> -        this.emit("click");
> +        this.emit("click", win.BrowserApp.selectedTab);

Please use `tabTracker.activeTab` instead. And please assign that to `tab` rather than creating a `win` variable.
Attachment #8845076 - Flags: review?(kmaglione+bmo) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c3f5c270df0e
Fix missing tab details in pageAction.onClicked events on Android. r=kmag
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c3f5c270df0e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.