1345606 - setRangeText should mark the input value dirty

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

Spec bug at https://github.com/whatwg/html/issues/2425

Right now we have inconsistent behavior between input and textarea.  Bug 1343037 makes them consistent but imo wrong (matching the input behavior, and the spec, but not Chrome or Safari).  I think, per the spec issue, we should match Chrome and Safari, and our old textarea behavior, here.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: setRangeText should mark the text control as dirty

MozReview-Commit-ID: FXWCbwJwLNF

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Per IRC discussion, maybe slightly saner behavior for defaultValue changes when there is a selection around

It's not that much saner when there is an _editor_, as the tests will show

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8845163 [details] [diff] [review]
Per IRC discussion, maybe slightly saner behavior for defaultValue changes when there is a selection around

bzexport fail

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b81ec733e5c2
setRangeText should mark the text control as dirty.  r=ehsan

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=82842964&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/a6a31be45918

Comment 6

[Boris Zbarsky [:bzbarsky]]

The issue is the patches for bug 1345237.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Er, bug 1343037.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e4d08c9ffd0
setRangeText should mark the text control as dirty.  r=ehsan

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/8e4d08c9ffd0