1345640 - A new UICollectionViewFlowLayout for ActivityStream

Status: RESOLVED FIXED

(Firefox for iOS :: Home screen, enhancement, P1)

Description

[Farhan Patel [:farhan]]

Attachment: Pasted image at 2017_03_07 05_18 PM.png

ActivtyStream will be a UICollectionView now in order to support iPad and to have highlights side by side on iPhone6/6+. 

We will need a new FlowLayout that supports this layout. It can be based off of Apple's UICollectionViewFlowLayout instead of creating our own from scratch. Look at the screenshot to make sure the layout is complete. 

There should be
- A section for a single ASHorizontalScrollCell (TopSites)
- Headers for both sections.
- Highlights in the last section. 
- An optional section that appears when no highlights are present (Highlight fox onboarding)

Pretty standard stuff. So UICollectionViewFlowLayout should work without much modification.

Comment 1

[Farhan Patel [:farhan]]

This one should probably be done at the end. After all the UICollectionViewCells have been converted.

Comment 2

[Bryan Munar (:bkmunar)]

Attachment: PR - encompasses several bugs in one (will mark as resolved after r+)

Comment 3

[Farhan Patel [:farhan]]

Attachment: Pull Request

Sorry that this PR is broken into so many different bugs. The goal in the beginning of opening all these bugs was to make it easy for Bryan and myself to work on this together, commiting to the same branch before it was merged into master (like the swift 3 migration) but that never ended up happening.

Comment 4

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/58ededc6e2a534df3b2d77883319346774fb1da3