In nsComputedDOMStyle::SetValueToStyleImage, use the URL stored in the nsStyleImage's mImageValue if we had some problem resolving the imgRequestProxy

RESOLVED FIXED in Firefox 55

Status

()

Core
Layout
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: u459114, Assigned: u459114)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8845238 - Flags: review?(cam)

Comment 3

a year ago
mozreview-review
Comment on attachment 8845238 [details]
Bug 1345739 - Implement nsStyleImageRequest::GetImageURI.

https://reviewboard.mozilla.org/r/118426/#review120380

Thanks for fixing this.

::: layout/style/nsStyleStruct.cpp:2269
(Diff revision 2)
> +      return uri.forget();
> +    }
> +  }
> +
> +  // If we had some problem resolving the mRequestProxy, use the URL stored
> +  // in the  mImageValue.

Nit: remove one of the spaces after "the".
Attachment #8845238 - Flags: review?(cam) → review+
Comment hidden (mozreview-request)

Comment 5

a year ago
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7368729b7ba0
Implement nsStyleImageRequest::GetImageURI. r=heycam

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/7368729b7ba0
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.