1345739 - In nsComputedDOMStyle::SetValueToStyleImage, use the URL stored in the nsStyleImage's mImageValue if we had some problem resolving the imgRequestProxy

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[u459114]

While working on 1301245, I found these comments [1]/[2]. So, file this bug  
to fix these XXX

[1] https://hg.mozilla.org/mozilla-central/file/9f17f5e31f3d/layout/style/nsComputedDOMStyle.cpp#l2268
[2] https://hg.mozilla.org/mozilla-central/file/9f17f5e31f3d/layout/style/nsComputedDOMStyle.cpp#l3697

Comment 1

[u459114]

Attachment: Bug 1345739 - Implement nsStyleImageRequest::GetImageURI.

Review commit: https://reviewboard.mozilla.org/r/118426/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118426/

Comment 2

[u459114]

Comment on attachment 8845238 [details]
Bug 1345739 - Implement nsStyleImageRequest::GetImageURI.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/118426/diff/1-2/

Comment 3

[Cameron McCormack (:heycam)]

Comment on attachment 8845238 [details]
Bug 1345739 - Implement nsStyleImageRequest::GetImageURI.

https://reviewboard.mozilla.org/r/118426/#review120380

Thanks for fixing this.

::: layout/style/nsStyleStruct.cpp:2269
(Diff revision 2)
> +      return uri.forget();
> +    }
> +  }
> +
> +  // If we had some problem resolving the mRequestProxy, use the URL stored
> +  // in the  mImageValue.

Nit: remove one of the spaces after "the".

Comment 4

[u459114]

Comment on attachment 8845238 [details]
Bug 1345739 - Implement nsStyleImageRequest::GetImageURI.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/118426/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7368729b7ba0
Implement nsStyleImageRequest::GetImageURI. r=heycam

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7368729b7ba0