Closed Bug 1345739 Opened 5 years ago Closed 5 years ago

In nsComputedDOMStyle::SetValueToStyleImage, use the URL stored in the nsStyleImage's mImageValue if we had some problem resolving the imgRequestProxy

Categories

(Core :: Layout, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: u459114, Assigned: u459114)

Details

Attachments

(1 file)

Attachment #8845238 - Flags: review?(cam)
Comment on attachment 8845238 [details]
Bug 1345739 - Implement nsStyleImageRequest::GetImageURI.

https://reviewboard.mozilla.org/r/118426/#review120380

Thanks for fixing this.

::: layout/style/nsStyleStruct.cpp:2269
(Diff revision 2)
> +      return uri.forget();
> +    }
> +  }
> +
> +  // If we had some problem resolving the mRequestProxy, use the URL stored
> +  // in the  mImageValue.

Nit: remove one of the spaces after "the".
Attachment #8845238 - Flags: review?(cam) → review+
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7368729b7ba0
Implement nsStyleImageRequest::GetImageURI. r=heycam
https://hg.mozilla.org/mozilla-central/rev/7368729b7ba0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.