Pull mozbase tests out of 'make-check' on OSX and into their own task

NEW
Unassigned

Status

enhancement
P3
normal
3 years ago
Last year

People

(Reporter: ahal, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Dustin wrote up a bunch of the legwork to get "job" tasks working on OSX in bug 1337903. Once that lands we can look into running mozbase tests as a standalone task there.

We'll roughly need to:
1) Annotate all the mozbase manifests so 'subsuite' applies on OSX
2) Add the 'macosx64/opt' platform to the mozbase taskcluster config
Can we try to get those tests running on Mac OS again now given that bug 1337903 is fixed? Especially I would like to see the mozprocess tests running on that platform.
For context this was filed just before I left on parental leave. I looked at it briefly when I got back, but there is still a lot of taskcluster legwork to do. We need to support running 'job' tasks on OSX, which I didn't immediately know how to accomplish.

I'm not saying it'll be terribly difficult or anything (though it might be), just that the path here is unknown to me and I'm not sure when/if I'll have a chance to pick this up again.

I do agree that it's important though.
(In reply to Andrew Halberstadt [:ahal] from comment #2)
> For context this was filed just before I left on parental leave. I looked at
> it briefly when I got back, but there is still a lot of taskcluster legwork
> to do. We need to support running 'job' tasks on OSX, which I didn't
> immediately know how to accomplish.

Can you please tell what this is? Is no other job on MacOS using this type of job yet? Do you have a bug number for its implementation on Linux? It would help a lot. Or is there someone else whom we should better ask? Thanks.
Flags: needinfo?(ahalberstadt)
So I found bug 1003417 which did the leg work for mozbase unit tests to be run as separate test job. So to get MacOS support added we will have to get the mozbase manifest files updated:

before: subsuite = mozbase, os == "linux"
after: subsuite = mozbase, os != "win" (or whatever the windows identifier is, I haven't checked that yet)

This would remove the mozbase unit tests from the default subsuite. 

Then the following commit added the mozbase python-test job for Linux:
https://hg.mozilla.org/mozilla-central/rev/22d650dc282e

As Andrew mentioned above we will have to check what needs to be done before we can enable those for MacOS too. At least the changes from bug 1320194 don't look to be Linux only which is good.

In https://reviewboard.mozilla.org/r/117678/diff/2-3/ we temporarily removed the platform coverage for MacOS, and https://hg.mozilla.org/mozilla-central/rev/7ee4038b4628 moved platform definitions to `job-defaults` so that we only run those python-tests on Linux. 

Being able to have mozbase jobs running on OS X (maybe not all of them) we would have to add custom settings to the mozbase section in python.yml.
So the only worker for OS X we currently have is "releng-hardware/gecko-t-osx-1010", but as it looks like it doesn't allow the usage of "implementation: native-engine".

Dustin, if you can remember, would you mind giving feedback in what we will have to do in getting those mozbase tests running in regards of taskcluster worker changes? Thanks.
Flags: needinfo?(dustin)
I don't remember exactly what was needed anymore, but I'll do a bit of investigation and file a bug that blocks this one with the results.
Flags: needinfo?(ahalberstadt)
Depends on: 1436037
native-engine isn't allowed for that worker because it doesn't run native-engine -- it's running generic-worker.  I believe the bug that ahal filed will allow use of run-task with generic-worker.
Flags: needinfo?(dustin)
Priority: -- → P3
You need to log in before you can comment on or make changes to this bug.