Closed Bug 1345897 Opened 3 years ago Closed 3 years ago

Use a separate error function for sentinel errors

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr45 --- wontfix
firefox52 --- wontfix
firefox-esr52 --- wontfix
firefox53 --- wontfix
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: mccr8, Assigned: mccr8)

References

Details

Attachments

(1 file)

checkedRead uses the same error message for whatever it is checking as it does for the sentinel, which is a little confusing. See bug 1345872. A separate function for all sentinel checking failures is probably ok.
Assignee: nobody → continuation
This patch was much grosser than I'd have liked.
Comment on attachment 8846110 [details]
Bug 1345897 - Use a separate error function for sentinel errors.

https://reviewboard.mozilla.org/r/119192/#review121430
Attachment #8846110 - Flags: review?(kchen) → review+
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c93713825d2e
Use a separate error function for sentinel errors. r=kanru
https://hg.mozilla.org/mozilla-central/rev/c93713825d2e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment on attachment 8846110 [details]
Bug 1345897 - Use a separate error function for sentinel errors.

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: No direct impact. This separates out some signatures for diagnostic crashes we have on Aurora and Nightly.
[Is this code covered by automated tests?]: somewhat
[Has the fix been verified in Nightly?]: yes, I confirmed that the new signature shows up.
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It just adds a new crashing method and calls it instead of another crashing method sometimes.
[String changes made/needed]: none
Attachment #8846110 - Flags: approval-mozilla-aurora?
No need to backport this except to Aurora, as we only have sentinels on Nightly and Aurora.
Comment on attachment 8846110 [details]
Bug 1345897 - Use a separate error function for sentinel errors.

This patch can help for diagnostic crashes on Aurora and Nightly. Aurora54+.
Attachment #8846110 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Depends on: 1348838
You need to log in before you can comment on or make changes to this bug.