1345897 - Use a separate error function for sentinel errors

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Andrew McCreight [:mccr8]]

checkedRead uses the same error message for whatever it is checking as it does for the sentinel, which is a little confusing. See bug 1345872. A separate function for all sentinel checking failures is probably ok.

Comment 1

[Andrew McCreight [:mccr8]]

This patch was much grosser than I'd have liked.

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: Bug 1345897 - Use a separate error function for sentinel errors.

Using a separate error function will distinguish mismatched sentinels
from other errors, such as array length problems.

Review commit: https://reviewboard.mozilla.org/r/119192/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/119192/

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 8846110 [details]
Bug 1345897 - Use a separate error function for sentinel errors.

https://reviewboard.mozilla.org/r/119192/#review121430

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c93713825d2e
Use a separate error function for sentinel errors. r=kanru

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c93713825d2e

Comment 6

[Andrew McCreight [:mccr8]]

Comment on attachment 8846110 [details]
Bug 1345897 - Use a separate error function for sentinel errors.

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: No direct impact. This separates out some signatures for diagnostic crashes we have on Aurora and Nightly.
[Is this code covered by automated tests?]: somewhat
[Has the fix been verified in Nightly?]: yes, I confirmed that the new signature shows up.
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It just adds a new crashing method and calls it instead of another crashing method sometimes.
[String changes made/needed]: none

Comment 7

[Andrew McCreight [:mccr8]]

No need to backport this except to Aurora, as we only have sentinels on Nightly and Aurora.

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8846110 [details]
Bug 1345897 - Use a separate error function for sentinel errors.

This patch can help for diagnostic crashes on Aurora and Nightly. Aurora54+.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/192e5195b97d