134593 - Master password prompt reasked upon cancel then form submit

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[Philip White]

There are two reproducible instances where the pop-up password prompt is
displayed twice:

1) The password manager recognizes a form and wants to fill it in and I press
Cancel at the pop-up password prompt -- it prompts me again!

2) It recognizes a form, asks me for the password, I enter it, it fills in the
form, I submit it, and the manager asks for my password again!  Probably this is
to save my "updated" login, even though it was not updated.  Suggestion: check
to see if the login info was actually edited and only try to save it if it was
modified.

My Master Password setting is to prompt every time it's needed.  However, the
master password should not be needed two times for every form!

Thank you for reading.

Comment 1

[Terri Preston]

Reporter, could you please include your build number?  I have a feeling this is
a dupe of http://bugzilla.mozilla.org/show_bug.cgi?id=114895?  Thanks for
testing mozilla :-)

Comment 2

[Philip White]

I am using a nightly build from two days ago:  2002032916

That bug does not sound like the same thing -- the reporter there is saying that
even though Mozilla fills in his values with the saved data, the web site is
rejecting it.  At least that's what I gathered from his report.

My bug is that Mozilla is being too persistent -- even if I click Cancel at the
prompt, meaning that I don't want Mozilla to fill in the form with any saved
values this time, it prompts me AGAIN.
Also, after I enter my password and it fills in my data, I immediately click
Submit without any modifications, it asks for my password AGAIN as if it's
trying to save the "updated" data back to the database.

Another related problem that I noticed after I submitted this is that on
FastMail.FM when I try to log on, it first prompts me for the master password on
the login page.  I cancel the request.  It prompts me again.  I cancel that as
well.  I then enter my data and submit it.  It prompts to save the password.  I
cancel that.  It prompts me again.  I cancel that again.  Then it pops up a
question whether I want to save it or not.  If you were counting this, that's
FIVE POP-UPS for one login form.


VERY, EXTREMELY annoying.

Comment 3

[Stephen P. Morse]

Try using a fresh profile and see if the same thing happens.  If the fresh 
profile clears things up, then this is indeed a dup of bug 114895.

Comment 4

[Pete Boyd]

I didn't read it all but it seems bug 114895 was about the password not working,
where-as this bug is about being asked for the password twice and the password
working

point 1. sounds like a bug that was fixed a while back.
point 2. sounds like a differnet bug (possibly bug 34507), I think I'm seeing
this currently when using Mozillazine, where I've entered a comment with my
username and password and the subject has been saved by the Password Manager and
so wants to save again when there's a different subject line; with encryption
turned off

Comment 5

[Michael Lefevre]

doesn't really sound like this is the same as bug 34507...

reporter (Philip): can you reproduce this problem with a recent build of mozilla
(e.g. 1.0.0) and a new profile?  if so, please comment to say so.  if not,
please mark this bug as "WORKSFORME". thanks.

Comment 6

[Vidar Haarr (not reading bugmail)]

CONFIRMED on 2002062508 (trunk), WinXP.

Comment 7

[Terri Preston]

*** Bug 154369 has been marked as a duplicate of this bug. ***

Comment 8

[Stephen P. Morse]

Reassigning to Personal Security Manager since that is the component that puts 
up the master password dialog.

Comment 9

[Stephane Saux]

->Kai
->Future

We'll take a look.

Comment 10

[Torben]

Happens on Mac OS X too (1.5 RC2) -> All/All

Comment 11

[John G. Myers]

*** Bug 210433 has been marked as a duplicate of this bug. ***

Comment 12

[John G. Myers]

Narrowing this bug to only address point 2.

Comment 13

[Meaker]

(In reply to comment #12)
> Narrowing this bug to only address point 2.
> 

The bug in which Moz asks for the Master Password twice (on entry to page where
saved passwords are auto-entered, and then *again* when "submit" or "enter" is
pressed on this page) STILL exists. This must be a fairly easy bug to squash,
folks. It makes using encrypted passwords and a master password SUCH a hassle.
Please fix it. It's been known for several years now ...

Comment 14

[Meaker]

(In reply to comment #12)
> Narrowing this bug to only address point 2.
> 

The bug in which Moz asks for the Master Password twice (on entry to page where
saved passwords are auto-entered, and then *again* when "submit" or "enter" is
pressed on this page) STILL exists. This must be a fairly easy bug to squash,
folks. It makes using encrypted passwords and a master password SUCH a hassle.
Please fix it. It's been known for several years now ...

Geez, even having trouble entering this bug report because of this bug. And I'm
using Moz 1.8a4.

Comment 15

[Justin Dolske [:Dolske]]

The first issue is fixed by bug 381164. One issue per bug, please.

I don't see any way around the second issue, other than to disable saving passwords. When you save a login, it needs to see if that login is already saved, to avoid asking "do you want to save this login?" It needs the master password to decrypt existing entries and check.