1345972 - Android emulator tests download tooltool.py from github

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect, P3)

Description

[Geoff Brown [:gbrown] (pto Apr 11-18)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1276813#c27

See https://dxr.mozilla.org/mozilla-central/rev/58753259bfeb3b818eac7870871b0aae1f8de64a/testing/mozharness/mozharness/mozilla/tooltool.py#51


I think the tooltool.py script can be found on the docker image, or in $topsrcdir.

Comment 1

[Geoff Brown [:gbrown] (pto Apr 11-18)]

tooltool.py is not in the initial docker image for Android test jobs.

It is in-tree at $topsrcdir/taskcluster/docker/recipes/tooltool.py, but android_emulator_unittest.py tries to set up the emulator (tooltool downloads of emulator and avd) before fetching the source: Android test jobs start faster by fetching and unarchiving source, etc while the emulator is starting.

I wonder if tooltool.py could be treated more like scripts/xvfb.sh or bin/run-mozharness.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

It could, yes :)  Make it so!

Comment 3

[Geoff Brown [:gbrown] (pto Apr 11-18)]

Attachment: add tooltool.py to docker image and use it from android tests

https://treeherder.mozilla.org/#/jobs?repo=try&revision=71f00f978963d52717f098a5efb7c05a33d9b657

https://treeherder.mozilla.org/logviewer.html#?job_id=158266721&repo=try&lineNumber=657

[task 2018-01-24T19:02:11.661Z] 19:02:11     INFO - Calling ['python', '/builds/worker/scripts/tooltool.py', '--url', 'http://relengapi/tooltool/', 'fetch', '-m', '/builds/worker/workspace/build/.android/releng.manifest', '-o', '-c', '/builds/worker/tooltool_cache'] with output_timeout 600
[task 2018-01-24T19:02:11.705Z] 19:02:11     INFO -  INFO - File AVDs-armv7a-android-4.3.1_r1-build-2016-08-02.tar.gz not present in local cache folder /builds/worker/tooltool_cache
[task 2018-01-24T19:02:11.706Z] 19:02:11     INFO -  INFO - Attempting to fetch from 'http://relengapi/tooltool/'...
[task 2018-01-24T19:02:14.919Z] 19:02:14     INFO -  INFO - File AVDs-armv7a-android-4.3.1_r1-build-2016-08-02.tar.gz fetched from http://relengapi/tooltool/ as /builds/worker/workspace/build/.android/tmpcIsZWt
[task 2018-01-24T19:02:16.123Z] 19:02:16     INFO -  INFO - File integrity verified, renaming tmpcIsZWt to AVDs-armv7a-android-4.3.1_r1-build-2016-08-02.tar.gz
[task 2018-01-24T19:02:16.123Z] 19:02:16     INFO -  INFO - Updating local cache /builds/worker/tooltool_cache...
[task 2018-01-24T19:02:16.252Z] 19:02:16     INFO -  INFO - Local cache /builds/worker/tooltool_cache updated with AVDs-armv7a-android-4.3.1_r1-build-2016-08-02.tar.gz
[task 2018-01-24T19:02:16.253Z] 19:02:16     INFO -  INFO - untarring "AVDs-armv7a-android-4.3.1_r1-build-2016-08-02.tar.gz"
[task 2018-01-24T19:02:21.230Z] 19:02:21     INFO - Return code: 0

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8945189 [details] [diff] [review]
add tooltool.py to docker image and use it from android tests

Review of attachment 8945189 [details] [diff] [review]:
-----------------------------------------------------------------

good idea!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/544e1a63dd16
Do not download tooltool.py during Android test tasks; r=jmaher

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f13041855ebc

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/544e1a63dd16