1345980 - Add test-type tags to all mochitest job types

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[William Lachance (:wlach)]

This is necessary for us so that the treeherder side of the actions triggering code can recognize them as being retriggerable (right now we're only doing this for plain)

Comment 1

[William Lachance (:wlach)]

Attachment: Bug 1345980 - Mark up all taskcluster mochitest jobs with tag 'test-type: mochitest'

Necessary for treeherder action retriggering code to recognize them as supporting
this action.

Review commit: https://reviewboard.mozilla.org/r/118732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118732/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8845599 [details]
Bug 1345980 - Mark up all taskcluster mochitest jobs with tag 'test-type: mochitest'

https://reviewboard.mozilla.org/r/118732/#review120668

Jonas will be glad to see tags getting some use.

Is this just for these specific test suites, or for all mochitests, or ..?  I'm wondering if this wouldn't be better accomplished with a transform based on the suite.

Comment 3

[William Lachance (:wlach)]

Comment on attachment 8845599 [details]
Bug 1345980 - Mark up all taskcluster mochitest jobs with tag 'test-type: mochitest'

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/118732/diff/1-2/

Comment 4

[William Lachance (:wlach)]

Comment on attachment 8845599 [details]
Bug 1345980 - Mark up all taskcluster mochitest jobs with tag 'test-type: mochitest'

https://reviewboard.mozilla.org/r/118732/#review120668

Good idea! I hadn't heard of transforms before. Created one which I think should do the trick. :)

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8845599 [details]
Bug 1345980 - Mark up all taskcluster mochitest jobs with tag 'test-type: mochitest'

https://reviewboard.mozilla.org/r/118732/#review120692

A more concise way to say the same thing.  Nice work!

::: taskcluster/taskgraph/transforms/tests.py:373
(Diff revision 2)
>  
>  @transforms.add
> +def set_mochitest_test_type(config, tests):
> +    for test in tests:
> +        if type(test['suite']) == str and test['suite'].startswith('mochitest'):
> +            tags = test.get('tags', {})

test.setdefault('tags', {})['test-type'] = 'mochitest'

Comment 6

[William Lachance (:wlach)]

Comment on attachment 8845599 [details]
Bug 1345980 - Mark up all taskcluster mochitest jobs with tag 'test-type: mochitest'

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/118732/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32c79b4aeaaa
Mark up all taskcluster mochitest jobs with tag 'test-type: mochitest' r=dustin

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/32c79b4aeaaa

Comment 9

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1342495 > mozilla:master

Comment 10

[William Lachance (:wlach)]

Comment on attachment 8846076 [details] [review]
[treeherder] wlach:1342495 > mozilla:master

Argh, ignore that.

Comment 11

[GitHub Autolander Bot]

Attachment: [treeherder] wlach:1342495 > mozilla:master

Comment 12

[William Lachance (:wlach)]

Comment on attachment 8846077 [details] [review]
[treeherder] wlach:1342495 > mozilla:master

oh autolander...